OpenGL: Handle 0 exponent in float/half conversion#72914
Merged
akien-mga merged 1 commit intoFeb 9, 2023
Conversation
clayjohn
approved these changes
Feb 8, 2023
clayjohn
left a comment
Member
There was a problem hiding this comment.
Looks great! I tested locally as well and confirm it fixes the bugs listed.
This was referenced Feb 8, 2023
Member
|
Likely also fixes #71731 |
Member
|
Thanks! |
This was referenced Feb 15, 2023
This was referenced Aug 29, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72882 , Fixes #66462 , Fixes #66459
Supersedes #72908 and #72329
Simpler solution only checking for 0 (or too small) exponent
bugsquad edit: Fixes #71731