OpenGL : Refact half to float and float to half conversion#72908
OpenGL : Refact half to float and float to half conversion#72908JonqsGames wants to merge 1 commit into
Conversation
|
I think that there might be some licensing issues. All user contributions on SO are licensed under CC-BY-SA (unless stated otherwise obv), which is incompatible with MIT. |
|
@riteo sorry didn't knew that. Not sure how to handle that. Since i understand it, i could refactor to make it less like the original answer but i feel like it's cheating. |
|
He links his research paper which his SO post is based on, but it's hard to say what kind of copyright it has. Some educational institutions can have pretty liberal licenses for their research data, but you'd have to dig a bit. Or maybe even ask the person directly if they or any of the co-authors are allowed to re-license the code snippets. However, he also seems to run this project: https://github.com/ProjectPhysX/FluidX3D, which has this pretty limiting (custom?) license: https://github.com/ProjectPhysX/FluidX3D/blob/master/LICENSE.md. Seems there is similar code in this file: https://github.com/ProjectPhysX/FluidX3D/blob/master/src/kernel.cpp |
|
@clayjohn i agree. |
Indeed, there may be an easy workaround here. Also these functions are not exposed to users, they are just used to implement pack/unpackHalf2x16 |
|
Superseded by #72914 |
Fixes: #72882
Based on : https://stackoverflow.com/a/60047308
I think this solution is more robust than the previous one, still has some edge case for not normalized float but i don't think this is an issue since all float come from the same source.
Bugsquad edit
Also fixes: #66462
Fixes: #66459
Supersedes: #72329