Fix DirectionalLight3D shadow opacity on Forward Mobile rendering backend#71690
Merged
akien-mga merged 1 commit intoJan 23, 2023
Conversation
clayjohn
reviewed
Jan 19, 2023
4f927b2 to
d84c952
Compare
clayjohn
approved these changes
Jan 22, 2023
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a line of code that was only added to
scene_forward_clustered.glslby #61893.Thanks @lostminds for spotting the issue 🙂
This closes #71606.
Testing project: test_directionallight3d_shadow_opacity_mobile.zip
Preview
simplescreenrecorder-2023-01-19_19.39.45.mp4