Skip to content

Fix ColorPicker sliders in overbright RGB#102240

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
KoBeWi:RAWR
Apr 22, 2025
Merged

Fix ColorPicker sliders in overbright RGB#102240
Repiteo merged 1 commit into
godotengine:masterfrom
KoBeWi:RAWR

Conversation

@KoBeWi

@KoBeWi KoBeWi commented Jan 31, 2025

Copy link
Copy Markdown
Member

Fixes #62894
Supersedes #62913

ROyCRS3DYT.mp4

I removed the next_power_of_2 thing, which dates back to #17383 with no explanation. Instead I made RGB mode SpinBoxes allow greater values (inspired by #88072). allow_greater is also enabled in RAW mode; this technically allows to limit the sliders to 10.0, while still allowing bigger values.

@KoBeWi KoBeWi added this to the 4.4 milestone Jan 31, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner January 31, 2025 13:00
@Repiteo Repiteo modified the milestones: 4.4, 4.5 Feb 24, 2025

@Repiteo Repiteo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Repiteo Repiteo merged commit 4d48c8f into godotengine:master Apr 22, 2025
@Repiteo

Repiteo commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switching to RAW mode and then to RGB will change slider max value until refreshed

2 participants