fix switching RAW mode to RGB mode issue#62913
Closed
KuaiDain wants to merge 1 commit into
Closed
Conversation
Member
|
Doesn't this always clamp the value to 255? It means your color is truncated when you switch from RAW to RGB. Not sure if it's desired 🤔 |
Member
|
You can have different "intensity" value that is multiplied with a rgba8 to store the original value, but converting values outside of 0 to 1 to RGBA8 is a lossy conversion. Would like some opinions. |
Author
|
thanks for your advice Color ColorModeRGB::get_color() const {
Vector<float> values = color_picker->get_active_slider_values();
Color color;
for (int i = 0; i < 4; i++) {
color.components[i] = values[i] / 255.0;
}
return color;
}except RAW mode, other mode do a calculation, then store back to color Color ColorModeRAW::get_color() const {
Vector<float> values = color_picker->get_active_slider_values();
Color color;
for (int i = 0; i < 4; i++) {
color.components[i] = values[i];
}
return color;
}
|
Member
Contributor
|
Superseded by #102240 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #62894
when result of
color.components[idx] * 255.0beyond 255, this issue will happen, so i modified this function as other mode