Better tab support for color picker#17383
Merged
Conversation
Author
|
Added better support for HDR colors: byte values are now not clipped to 255 in these cases and the hex form gets hidden if you are in HDR range. |
Member
|
Thanks, nice UX improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings tab-select-all as known from the property editors to the color picker. Also fixes broken initial focus and selection on html input LineEdit in master.
Current master:
https://www.dropbox.com/s/1p8nhqjuh687sbo/cp-master.mp4?dl=0
With PR:
https://www.dropbox.com/s/czwmf0of05q5k4p/cp-pr.mp4?dl=0