stages/authenticator_webauthn: optimize device types creation#9932
Merged
stages/authenticator_webauthn: optimize device types creation#9932
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs canceled.
|
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
c2c3264 to
15f069a
Compare
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9932 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 710 710
Lines 34767 34771 +4
=======================================
+ Hits 32205 32210 +5
+ Misses 2562 2561 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-afe1b79fec5b97ee1b8bde8351f31905098d5d45
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sFor arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-afe1b79fec5b97ee1b8bde8351f31905098d5d45-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-ghcr.io/goauthentik/dev-server:gh-afe1b79fec5b97ee1b8bde8351f31905098d5d45For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-ghcr.io/goauthentik/dev-server:gh-afe1b79fec5b97ee1b8bde8351f31905098d5d45-arm64Afterwards, run the upgrade commands from the latest release notes. |
BeryJu
approved these changes
Jun 1, 2024
Member
BeryJu
left a comment
There was a problem hiding this comment.
That's a good way to fix it, I would've probably added a lock to it instead
I think we might still want to combine the tasks as a system task and set it on a schedule so we don't have to dispatch it on startup since even with the optimisation that's not great
6 tasks
kensternberg-authentik
added a commit
that referenced
this pull request
Jun 11, 2024
* main: (44 commits) translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9943) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9944) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9942) stages/authenticator_webauthn: migrate device type import to systemtask and schedule (#9958) website: bump prettier from 3.2.5 to 3.3.0 in /website (#9951) web: bump yaml from 2.4.2 to 2.4.3 in /web (#9945) web: bump prettier from 3.2.5 to 3.3.0 in /web (#9946) core: bump uvicorn from 0.30.0 to 0.30.1 (#9948) core: bump ruff from 0.4.6 to 0.4.7 (#9949) website: bump the docusaurus group in /website with 9 updates (#9950) web: bump prettier from 3.2.5 to 3.3.0 in /tests/wdio (#9952) web: bump chromedriver from 125.0.2 to 125.0.3 in /tests/wdio (#9953) core: groups: optimize recursive children query (#9931) core, web: update translations (#9938) stages/authenticator_webauthn: optimize device types creation (#9932) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9936) providers/oauth2: don't handle api scope as special scope (#9910) core: bump goauthentik.io/api/v3 from 3.2024042.8 to 3.2024042.9 (#9915) web: bump the storybook group in /web with 7 updates (#9917) website/integrations: firezone: remove question mark typo and remove promotional sentence (#9927) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Small improvement to avoid long-running transactions.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)