Skip to content

core: groups: optimize recursive children query#9931

Merged
rissson merged 4 commits intomainfrom
django-cte-groups-recursive
Jun 3, 2024
Merged

core: groups: optimize recursive children query#9931
rissson merged 4 commits intomainfrom
django-cte-groups-recursive

Conversation

@rissson
Copy link
Member

@rissson rissson commented May 31, 2024

Details

Went down from 3 queries to 1.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

@rissson rissson self-assigned this May 31, 2024
@rissson rissson requested a review from a team as a code owner May 31, 2024 13:22
@netlify
Copy link

netlify bot commented May 31, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 3fd62c3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/665da3c0cb91450008703d74

@netlify
Copy link

netlify bot commented May 31, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 3fd62c3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/665da3c0650319000884e144

@codecov
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.62%. Comparing base (562c52a) to head (3fd62c3).

Files Patch % Lines
authentik/core/models.py 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9931      +/-   ##
==========================================
- Coverage   92.63%   92.62%   -0.02%     
==========================================
  Files         710      710              
  Lines       34771    34775       +4     
==========================================
  Hits        32209    32209              
- Misses       2562     2566       +4     
Flag Coverage Δ
e2e 49.65% <66.66%> (-0.01%) ⬇️
integration 25.50% <33.33%> (+0.01%) ⬆️
unit 90.08% <73.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-3fd62c3a2fbc0a04892ff6dbe9bc20ee72f60d02
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-3fd62c3a2fbc0a04892ff6dbe9bc20ee72f60d02-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-3fd62c3a2fbc0a04892ff6dbe9bc20ee72f60d02

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-3fd62c3a2fbc0a04892ff6dbe9bc20ee72f60d02-arm64

Afterwards, run the upgrade commands from the latest release notes.

rissson added 2 commits June 3, 2024 12:54
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson force-pushed the django-cte-groups-recursive branch from b66bc38 to 6d1fca7 Compare June 3, 2024 10:55
rissson added 2 commits June 3, 2024 12:57
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson requested a review from BeryJu June 3, 2024 11:06
@rissson rissson enabled auto-merge (squash) June 3, 2024 11:37
@rissson rissson merged commit a989390 into main Jun 3, 2024
@rissson rissson deleted the django-cte-groups-recursive branch June 3, 2024 11:49
kensternberg-authentik added a commit that referenced this pull request Jun 11, 2024
* main: (44 commits)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9943)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9944)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9942)
  stages/authenticator_webauthn: migrate device type import to systemtask and schedule (#9958)
  website: bump prettier from 3.2.5 to 3.3.0 in /website (#9951)
  web: bump yaml from 2.4.2 to 2.4.3 in /web (#9945)
  web: bump prettier from 3.2.5 to 3.3.0 in /web (#9946)
  core: bump uvicorn from 0.30.0 to 0.30.1 (#9948)
  core: bump ruff from 0.4.6 to 0.4.7 (#9949)
  website: bump the docusaurus group in /website with 9 updates (#9950)
  web: bump prettier from 3.2.5 to 3.3.0 in /tests/wdio (#9952)
  web: bump chromedriver from 125.0.2 to 125.0.3 in /tests/wdio (#9953)
  core: groups: optimize recursive children query (#9931)
  core, web: update translations (#9938)
  stages/authenticator_webauthn: optimize device types creation (#9932)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9936)
  providers/oauth2: don't handle api scope as special scope (#9910)
  core: bump goauthentik.io/api/v3 from 3.2024042.8 to 3.2024042.9 (#9915)
  web: bump the storybook group in /web with 7 updates (#9917)
  website/integrations: firezone: remove question mark typo and remove promotional sentence (#9927)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants