website/integrations: netbox: add missing scope configuration#9491
Merged
rissson merged 3 commits intogoauthentik:mainfrom May 21, 2024
Merged
website/integrations: netbox: add missing scope configuration#9491rissson merged 3 commits intogoauthentik:mainfrom
rissson merged 3 commits intogoauthentik:mainfrom
Conversation
Netbox does not seem to request the `roles` profile, so this scope is never sent. However, changing it to `profile` makes the integration work perfectly. Signed-off-by: Allan Eising <allan.eising@gmail.com>
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rissson
requested changes
Apr 29, 2024
Member
rissson
left a comment
There was a problem hiding this comment.
You need to set SOCIAL_AUTH_OIDC_SCOPE = ["openid", "profile", "email", "roles"] in the Netbox configuration for the roles scope to be requested. That configuration is indeed missing from the documentation. I'd rather we add that than use a well-known scope that doesn't fit the use case.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9491 +/- ##
=======================================
Coverage 92.38% 92.39%
=======================================
Files 704 704
Lines 34403 34403
=======================================
+ Hits 31784 31785 +1
+ Misses 2619 2618 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Contributor
Author
Contributor
Author
|
Updated with the suggested fix. |
rissson
approved these changes
May 21, 2024
kensternberg-authentik
added a commit
that referenced
this pull request
May 24, 2024
* main: (36 commits) ci: use container registry for container build cache (#9809) core: bump lxml from 5.2.1 to 5.2.2 (#9717) web: bump mermaid from 10.9.0 to 10.9.1 in /web (#9734) core: bump scim2-filter-parser from 0.5.0 to 0.5.1 (#9730) web: bump core-js from 3.37.0 to 3.37.1 in /web (#9733) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9729) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9802) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9803) core: bump sentry-sdk from 2.2.0 to 2.2.1 (#9807) web: bump the storybook group in /web with 7 updates (#9804) web: bump glob from 10.3.15 to 10.3.16 in /web (#9805) root: docker-compose: remove version top level element (#9631) core, web: update translations (#9790) web: bump API Client version (#9801) web/admin: rework initial wizard pages and add grid layout (#9668) website/integrations: discord: fix typo (#9800) website/integration/netbox: fix group custom pipeline example (#9738) root: add primary-replica db router (#9479) website/integrations: add three more policy-expressions to discord-docs (#5760) website/integrations: netbox: add missing scope configuration (#9491) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying the proposed documentation, I found that the group mapping did not work.
After troubleshooting for a while, it seems that Netbox does not seem to request the
rolesscope at all, so the Scope mapping is actually never used (or at least that is how I understand the problem).Changing the scope of the example provided to
profileinstead makes it work perfectly.This PR contains just this change in the documentation.