Skip to content

website/integrations: add three more policy-expressions to discord-docs#5760

Merged
tanberry merged 5 commits intogoauthentik:mainfrom
Keyinator:main
May 21, 2024
Merged

website/integrations: add three more policy-expressions to discord-docs#5760
tanberry merged 5 commits intogoauthentik:mainfrom
Keyinator:main

Conversation

@Keyinator
Copy link
Contributor

Changes

New Features

  • Add two policy-examples for syncing discord roles to authentik groups during enrollment or authentication

  • Add policy to store oauth-info and create an authentik-avatar-attribute during enrollment or authentication

Checklist

  • The documentation has been updated
  • The documentation has been formatted (make website)

…ps during enrollment or authentication

- Add policy to store oauth-info and create an authentik-avatar-attribute during enrollment or authentication
@netlify
Copy link

netlify bot commented May 25, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 4011c58
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/646fdfa98a04b5000907dd08
😎 Deploy Preview https://deploy-preview-5760--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tanberry tanberry added the status/reviewing thanks for opening, we're taking a look label Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (44d7e81) to head (4c5cbd9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5760      +/-   ##
==========================================
- Coverage   92.65%   92.63%   -0.02%     
==========================================
  Files         708      708              
  Lines       34619    34619              
==========================================
- Hits        32077    32071       -6     
- Misses       2542     2548       +6     
Flag Coverage Δ
e2e 49.61% <ø> (+0.02%) ⬆️
integration 25.34% <ø> (ø)
unit 90.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanberry
Copy link
Contributor

Hi @Keyinator thanks for this PR. It is marked as a draft... are you ready for it to be reviewed and hopefully merged?

@BeryJu BeryJu changed the title Add two more policy-expressions to discord-docs website/integrations: Add two more policy-expressions to discord-docs Mar 15, 2024
@BeryJu BeryJu added status/awaiting-contributor Awaiting a response from the contributor and removed status/reviewing thanks for opening, we're taking a look labels Mar 15, 2024
@BeryJu
Copy link
Member

BeryJu commented Mar 15, 2024

Hey @Keyinator thanks for the PR, do you want to make any other changes before we review or should we change a couple of final things ourselves and merge it?

@Keyinator
Copy link
Contributor Author

Hey @Keyinator thanks for the PR, do you want to make any other changes before we review or should we change a couple of final things ourselves and merge it?

Sorry for the late reply, I did not notice that the pr was awaiting an answer.

I will have another look at it over the weekend and see if there's any more details that can be improved.

@Keyinator Keyinator changed the title website/integrations: Add two more policy-expressions to discord-docs website/integrations: add two more policy-expressions to discord-docs Mar 17, 2024
@Keyinator Keyinator changed the title website/integrations: add two more policy-expressions to discord-docs website/integrations: add three more policy-expressions to discord-docs Mar 17, 2024
- Fixed issue with wrong return during provider-check
- Lint using black

Signed-off-by: Keyinator <k3yinator@gmail.com>
@netlify
Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 4c5cbd9
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/664bb1941ea50c00081c73b2

@netlify
Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 4c5cbd9
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/664bb1941f6a90000883042a
😎 Deploy Preview https://deploy-preview-5760--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Keyinator Keyinator marked this pull request as ready for review March 17, 2024 12:19
@Keyinator Keyinator requested a review from a team as a code owner March 17, 2024 12:19
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Keyinator for this contribution! A couple of nit-picks about capitalization, and one question, then let's get this merged!

Keyinator and others added 2 commits May 20, 2024 11:56
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Keyinator <k3yinator@gmail.com>
@Keyinator
Copy link
Contributor Author

All done @tanberry

@tanberry tanberry removed the status/awaiting-contributor Awaiting a response from the contributor label May 20, 2024
@tanberry
Copy link
Contributor

@Keyinator this PR apparently has merge conflicts... do you want to resolve the and push again, or I can... clone your branch and do it...? I think, lol.

@Keyinator
Copy link
Contributor Author

@Keyinator this PR apparently has merge conflicts... do you want to resolve the and push again, or I can... clone your branch and do it...? I think, lol.

Should be fixed now

@tanberry tanberry merged commit 0983235 into goauthentik:main May 21, 2024
@tanberry
Copy link
Contributor

tanberry commented May 21, 2024

Thank you so much for this contribution and for your perseverance, @Keyinator !

kensternberg-authentik added a commit that referenced this pull request May 24, 2024
* main: (36 commits)
  ci: use container registry for container build cache (#9809)
  core: bump lxml from 5.2.1 to 5.2.2 (#9717)
  web: bump mermaid from 10.9.0 to 10.9.1 in /web (#9734)
  core: bump scim2-filter-parser from 0.5.0 to 0.5.1 (#9730)
  web: bump core-js from 3.37.0 to 3.37.1 in /web (#9733)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9729)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9802)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9803)
  core: bump sentry-sdk from 2.2.0 to 2.2.1 (#9807)
  web: bump the storybook group in /web with 7 updates (#9804)
  web: bump glob from 10.3.15 to 10.3.16 in /web (#9805)
  root: docker-compose: remove version top level element (#9631)
  core, web: update translations (#9790)
  web: bump API Client version (#9801)
  web/admin: rework initial wizard pages and add grid layout (#9668)
  website/integrations: discord: fix typo (#9800)
  website/integration/netbox: fix group custom pipeline example (#9738)
  root: add primary-replica db router (#9479)
  website/integrations: add three more policy-expressions to discord-docs (#5760)
  website/integrations: netbox: add missing scope configuration (#9491)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants