Add missing commas, correction of spelling errors#8680
Merged
tanberry merged 2 commits intogoauthentik:mainfrom Feb 26, 2024
Merged
Add missing commas, correction of spelling errors#8680tanberry merged 2 commits intogoauthentik:mainfrom
tanberry merged 2 commits intogoauthentik:mainfrom
Conversation
✅ Deploy Preview for authentik canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
Hi @patsevanton thank you for your contribution. Good catch on the unneeded "s" on "infos". The use of a comma in the sentence in the blog is, well, debatable (we debate commas quite often here), but it does no harm to add so I will merge the entire PR. In general we don't rewrite blogs after they are published unless there is a typo or large error; rather we prefer to focus on any needed corrections in the actual technical documentation. |
tanberry
approved these changes
Feb 26, 2024
kensternberg-authentik
added a commit
that referenced
this pull request
Feb 27, 2024
* main: (75 commits) Add missing commas, correction of spelling errors (#8680) website/docs: Add documentation for Glitchtip (#8182) website: add solve gitea group does not take effect (#8413) enterprise: fix read_only activating when no license is installed (#8697) core: fix blueprint export (#8695) web: bump the sentry group in /web with 1 update (#8687) web: bump yaml from 2.3.4 to 2.4.0 in /web (#8689) web: bump the eslint group in /web with 1 update (#8688) core: bump pytest from 8.0.1 to 8.0.2 (#8693) website: bump @types/react from 18.2.57 to 18.2.58 in /website (#8690) web: bump the eslint group in /tests/wdio with 1 update (#8691) core: bump sentry-sdk from 1.40.4 to 1.40.5 (#8692) core: bump coverage from 7.4.1 to 7.4.3 (#8694) providers/oauth2: fix inconsistent `sub` value when setting via mapping (#8677) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8678) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8679) core, web: update translations (#8672) root: fix config loading after refactor during ruff migration (#8674) root: early spring clean for linting (#8498) website/integrations: multiple integration edits (#7923) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Add missing commas, correction of spelling errors
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)