Skip to content

root: early spring clean for linting#8498

Merged
BeryJu merged 20 commits intomainfrom
ci/remove-redundant
Feb 24, 2024
Merged

root: early spring clean for linting#8498
BeryJu merged 20 commits intomainfrom
ci/remove-redundant

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Feb 13, 2024

Details

  • Remove pylint since it keeps throwing false positives at random in CI pipelines requiring yet more pylint: disable= comments on everything
  • Remove pyright since we had to disable quite a few checks and lock it to an older version to make it not complain about django and celery
  • Instead use ruff for everything (keeping black and isort for now...?)

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners February 13, 2024 13:35
@netlify
Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 3d041c4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65d9fded67bdac0008cd354e

@netlify
Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit bd396ba
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65d3688fe6539b000886fd91
😎 Deploy Preview https://deploy-preview-8498--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu BeryJu mentioned this pull request Feb 14, 2024
6 tasks
@BeryJu BeryJu force-pushed the ci/remove-redundant branch from cc7768a to 6230857 Compare February 19, 2024 23:35
except RequestException as exc:
text = exc.response.text if exc.response else str(exc)
raise ValidationError({"oidc_well_known_url": text})
raise ValidationError({"oidc_well_known_url": text}) from None

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
except RequestException as exc:
text = exc.response.text if exc.response else str(exc)
raise ValidationError({"oidc_jwks_url": text})
raise ValidationError({"oidc_jwks_url": text}) from None

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
except InvalidRegistrationResponse as exc:
self.stage.logger.warning("registration failed", exc=exc)
raise ValidationError(f"Registration failed. Error: {exc}")
raise ValidationError(f"Registration failed. Error: {exc}") from None

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
@rissson
Copy link
Member

rissson commented Feb 20, 2024

Also, I removed isort and replaced it with ruff as well.

@BeryJu BeryJu force-pushed the ci/remove-redundant branch from b4937d9 to aec98a0 Compare February 22, 2024 13:14
@netlify
Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 3d041c4
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65d9fded90bcf40008e78b51
😎 Deploy Preview https://deploy-preview-8498--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-3d041c44ec77f06ad96f4d7d8fcc0790dd2bd702
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-3d041c44ec77f06ad96f4d7d8fcc0790dd2bd702-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-3d041c44ec77f06ad96f4d7d8fcc0790dd2bd702

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-3d041c44ec77f06ad96f4d7d8fcc0790dd2bd702-arm64

Afterwards, run the upgrade commands from the latest release notes.

BeryJu and others added 16 commits February 24, 2024 15:28
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
rissson and others added 3 commits February 24, 2024 15:29
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the ci/remove-redundant branch from 1fcadc2 to bdadbd4 Compare February 24, 2024 14:30
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit b225b02 into main Feb 24, 2024
@BeryJu BeryJu deleted the ci/remove-redundant branch February 24, 2024 17:13
kensternberg-authentik added a commit that referenced this pull request Feb 27, 2024
* main: (75 commits)
  Add missing commas, correction of spelling errors (#8680)
  website/docs: Add documentation for Glitchtip (#8182)
  website: add solve gitea group does not take effect (#8413)
  enterprise: fix read_only activating when no license is installed (#8697)
  core: fix blueprint export (#8695)
  web: bump the sentry group in /web with 1 update (#8687)
  web: bump yaml from 2.3.4 to 2.4.0 in /web (#8689)
  web: bump the eslint group in /web with 1 update (#8688)
  core: bump pytest from 8.0.1 to 8.0.2 (#8693)
  website: bump @types/react from 18.2.57 to 18.2.58 in /website (#8690)
  web: bump the eslint group in /tests/wdio with 1 update (#8691)
  core: bump sentry-sdk from 1.40.4 to 1.40.5 (#8692)
  core: bump coverage from 7.4.1 to 7.4.3 (#8694)
  providers/oauth2: fix inconsistent `sub` value when setting via mapping (#8677)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8678)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8679)
  core, web: update translations (#8672)
  root: fix config loading after refactor during ruff migration (#8674)
  root: early spring clean for linting (#8498)
  website/integrations: multiple integration edits (#7923)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants