web/admin: fix footer links not being parsed on settings page by rissson · Pull Request #8289 · goauthentik/authentik

rissson · 2024-01-24T14:51:44Z

Details

REPLACE ME

Checklist

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)
The translation files have been updated (make i18n-extract)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

netlify · 2024-01-24T14:51:49Z

✅ Deploy Preview for authentik-storybook ready!

Name	Link
🔨 Latest commit	`fc3741c`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/65b12a170ffb13000757f25b
😎 Deploy Preview	https://deploy-preview-8289--authentik-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

BeryJu · 2024-01-24T14:53:28Z

web/src/admin/admin-settings/AdminSettingsForm.ts

                    mode=${CodeMirrorMode.YAML}
-                    .parseValue=${false}
-                    value="${first(this._settings?.footerLinks, [])}"
+                    value="${YAML.stringify(first(this._settings?.footerLinks, []))}"


Suggested change

value="${YAML.stringify(first(this._settings?.footerLinks, []))}"

.value="${first(this._settings?.footerLinks, [])}"

with that the element will do the parsing itself

also on L164 could you change it to say JSON or YAML

With JSON and no parsing, it shows up as

Same with YAML.

did you add the . before the value=? Since when testing that works for me locally

I didn't, that might be it

Yep, it indeed does the trick. I left it as YAML though, as with JSON it still shows up as [object Object]

codecov · 2024-01-24T15:01:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ed2b74) 92.33% compared to head (fc3741c) 92.34%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8289   +/-   ##
=======================================
  Coverage   92.33%   92.34%           
=======================================
  Files         626      626           
  Lines       30917    30917           
=======================================
+ Hits        28548    28549    +1     
+ Misses       2369     2368    -1

Flag	Coverage Δ
e2e	`50.67% <ø> (+<0.01%)`	⬆️
integration	`26.16% <ø> (ø)`
unit	`89.59% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-01-24T15:13:23Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-web-fix-settings-footer-links-1706110795-fc3741c
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-web-fix-settings-footer-links-1706110795-fc3741c-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-web-fix-settings-footer-links-1706110795-fc3741c

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-web-fix-settings-footer-links-1706110795-fc3741c-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

* main: (109 commits) translate: Updates for file web/xliff/en.xlf in fr (#8296) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295) website: update wording (#8290) enterrpise: exclude inactive users from license (#8294) web: bump API Client version (#8292) core: compile backend translations (#8291) events: migrate SystemTasks to DB (#8159) web/admin: fix footer links not being parsed on settings page (#8289) root: fix system check warnings (#8277) web: bump API Client version (#8288) enterprise: add full audit log [AUTH-458] (#8177) web: bump the esbuild group in /web with 2 updates (#8282) web: bump the sentry group in /web with 1 update (#8281) web: bump @codemirror/lang-html from 6.4.7 to 6.4.8 in /web (#8283) core: bump bandit from 1.7.6 to 1.7.7 (#8285) core: bump selenium from 4.16.0 to 4.17.2 (#8284) core: bump github.com/go-openapi/runtime from 0.26.2 to 0.27.0 (#8287) core: bump github.com/google/uuid from 1.5.0 to 1.6.0 (#8286) website/docs: Improve example nginx reverse proxy config (#8160) translate: Updates for file web/xliff/en.xlf in zh_CN (#8274) ...

* main: (76 commits) core: compile backend translations (#8311) translate: Updates for file web/xliff/en.xlf in zh-Hans (#8304) translate: Updates for file web/xliff/en.xlf in zh_CN (#8305) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8300) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8301) events: fix missing labels on prometheus metrics (#8309) core: bump goauthentik.io/api/v3 from 3.2023106.4 to 3.2023106.5 (#8302) web: bump the wdio group in /tests/wdio with 4 updates (#8303) web: restore test anchor tag (#8298) translate: Updates for file web/xliff/en.xlf in fr (#8296) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295) website: update wording (#8290) enterrpise: exclude inactive users from license (#8294) web: bump API Client version (#8292) core: compile backend translations (#8291) events: migrate SystemTasks to DB (#8159) web/admin: fix footer links not being parsed on settings page (#8289) root: fix system check warnings (#8277) web: bump API Client version (#8288) enterprise: add full audit log [AUTH-458] (#8177) ...

* main: (131 commits) web: provide a context for checking the status of the enterprise license (#8153) core: compile backend translations (#8311) translate: Updates for file web/xliff/en.xlf in zh-Hans (#8304) translate: Updates for file web/xliff/en.xlf in zh_CN (#8305) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8300) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8301) events: fix missing labels on prometheus metrics (#8309) core: bump goauthentik.io/api/v3 from 3.2023106.4 to 3.2023106.5 (#8302) web: bump the wdio group in /tests/wdio with 4 updates (#8303) web: restore test anchor tag (#8298) translate: Updates for file web/xliff/en.xlf in fr (#8296) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295) website: update wording (#8290) enterrpise: exclude inactive users from license (#8294) web: bump API Client version (#8292) core: compile backend translations (#8291) events: migrate SystemTasks to DB (#8159) web/admin: fix footer links not being parsed on settings page (#8289) root: fix system check warnings (#8277) web: bump API Client version (#8288) ...

* main: (119 commits) web: provide a context for checking the status of the enterprise license (#8153) core: compile backend translations (#8311) translate: Updates for file web/xliff/en.xlf in zh-Hans (#8304) translate: Updates for file web/xliff/en.xlf in zh_CN (#8305) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8300) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8301) events: fix missing labels on prometheus metrics (#8309) core: bump goauthentik.io/api/v3 from 3.2023106.4 to 3.2023106.5 (#8302) web: bump the wdio group in /tests/wdio with 4 updates (#8303) web: restore test anchor tag (#8298) translate: Updates for file web/xliff/en.xlf in fr (#8296) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295) website: update wording (#8290) enterrpise: exclude inactive users from license (#8294) web: bump API Client version (#8292) core: compile backend translations (#8291) events: migrate SystemTasks to DB (#8159) web/admin: fix footer links not being parsed on settings page (#8289) root: fix system check warnings (#8277) web: bump API Client version (#8288) ...

* main: (30 commits) web: clear out selecteds list after an API event to ensure a fresh copy of the policies-to-delete list (#8125) web: provide dual-list multiselect with pagination (#8004) web: provide a context for checking the status of the enterprise license (#8153) core: compile backend translations (#8311) translate: Updates for file web/xliff/en.xlf in zh-Hans (#8304) translate: Updates for file web/xliff/en.xlf in zh_CN (#8305) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8300) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8301) events: fix missing labels on prometheus metrics (#8309) core: bump goauthentik.io/api/v3 from 3.2023106.4 to 3.2023106.5 (#8302) web: bump the wdio group in /tests/wdio with 4 updates (#8303) web: restore test anchor tag (#8298) translate: Updates for file web/xliff/en.xlf in fr (#8296) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295) website: update wording (#8290) enterrpise: exclude inactive users from license (#8294) web: bump API Client version (#8292) core: compile backend translations (#8291) events: migrate SystemTasks to DB (#8159) web/admin: fix footer links not being parsed on settings page (#8289) ...

rissson requested a review from a team as a code owner January 24, 2024 14:51

BeryJu reviewed Jan 24, 2024

View reviewed changes

rissson force-pushed the web-fix-settings-footer-links branch from 56d0c77 to e6d2175 Compare January 24, 2024 15:02

web/admin: fix footer links not being parsed on settings page

fc3741c

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

rissson force-pushed the web-fix-settings-footer-links branch from e6d2175 to fc3741c Compare January 24, 2024 15:17

BeryJu merged commit c0562bf into main Jan 24, 2024

BeryJu deleted the web-fix-settings-footer-links branch January 24, 2024 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

web/admin: fix footer links not being parsed on settings page#8289

web/admin: fix footer links not being parsed on settings page#8289
BeryJu merged 1 commit intomainfrom
web-fix-settings-footer-links

rissson commented Jan 24, 2024

Uh oh!

netlify bot commented Jan 24, 2024 •

edited

Loading

Uh oh!

BeryJu Jan 24, 2024

Uh oh!

BeryJu Jan 24, 2024

Uh oh!

rissson Jan 24, 2024

Uh oh!

rissson Jan 24, 2024

Uh oh!

BeryJu Jan 24, 2024 •

edited

Loading

Uh oh!

rissson Jan 24, 2024

Uh oh!

rissson Jan 24, 2024

Uh oh!

codecov bot commented Jan 24, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 24, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	value="${YAML.stringify(first(this._settings?.footerLinks, []))}"
	.value="${first(this._settings?.footerLinks, [])}"

Uh oh!

Conversation

rissson commented Jan 24, 2024

Details

Checklist

Uh oh!

netlify bot commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook ready!

Uh oh!

BeryJu Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

BeryJu Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

rissson Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

rissson Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

BeryJu Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rissson Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

rissson Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Jan 24, 2024 •

edited

Loading

BeryJu Jan 24, 2024 •

edited

Loading

codecov bot commented Jan 24, 2024 •

edited

Loading

github-actions bot commented Jan 24, 2024 •

edited

Loading