events: migrate SystemTasks to DB by BeryJu · Pull Request #8159 · goauthentik/authentik

BeryJu · 2024-01-13T21:49:26Z

Details

REPLACE ME

Checklist

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)
The translation files have been updated (make i18n-extract)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

netlify · 2024-01-13T21:49:31Z

✅ Deploy Preview for authentik-storybook canceled.

Name	Link
🔨 Latest commit	`c0e8350`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/65b11df321ba0200085406b3

github-actions · 2024-01-13T21:49:42Z

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

codecov · 2024-01-13T21:56:51Z

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (9ed2b74) 92.33% compared to head (c0e8350) 92.33%.

Files	Patch %	Lines
authentik/outposts/tasks.py	73.68%	5 Missing ⚠️
authentik/events/models.py	92.00%	4 Missing ⚠️
authentik/sources/oauth/tasks.py	66.66%	3 Missing ⚠️
authentik/blueprints/v1/tasks.py	75.00%	2 Missing ⚠️
authentik/events/system_tasks.py	96.49%	2 Missing ⚠️
authentik/events/tasks.py	66.66%	2 Missing ⚠️
authentik/events/api/tasks.py	98.24%	1 Missing ⚠️
authentik/events/signals.py	87.50%	1 Missing ⚠️
authentik/providers/scim/api/providers.py	75.00%	1 Missing ⚠️
authentik/providers/scim/tasks.py	91.66%	1 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8159      +/-   ##
==========================================
- Coverage   92.33%   92.33%   -0.01%     
==========================================
  Files         626      626              
  Lines       30917    30921       +4     
==========================================
+ Hits        28548    28550       +2     
- Misses       2369     2371       +2

Flag	Coverage Δ
e2e	`50.65% <58.87%> (-0.02%)`	⬇️
integration	`26.13% <42.60%> (-0.04%)`	⬇️
unit	`89.58% <89.94%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-01-14T16:15:25Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-events-migrate-tasks-db-1706108974-c0e8350
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-events-migrate-tasks-db-1706108974-c0e8350-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-events-migrate-tasks-db-1706108974-c0e8350

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-events-migrate-tasks-db-1706108974-c0e8350-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

…ck to module path Signed-off-by: Jens Langhammer <jens@goauthentik.io>

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

kensternberg-authentik

I've reviewed only the changes to the Web components, but they look well-made.

kensternberg-authentik · 2024-01-24T15:47:14Z

web/src/admin/events/utils.ts

    return html``;
 }
+
+export function EventUser(event: EventWithContext, truncateUsername?: number): TemplateResult {


Yay! Deduplication is ❤️.

* main: (109 commits) translate: Updates for file web/xliff/en.xlf in fr (#8296) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295) website: update wording (#8290) enterrpise: exclude inactive users from license (#8294) web: bump API Client version (#8292) core: compile backend translations (#8291) events: migrate SystemTasks to DB (#8159) web/admin: fix footer links not being parsed on settings page (#8289) root: fix system check warnings (#8277) web: bump API Client version (#8288) enterprise: add full audit log [AUTH-458] (#8177) web: bump the esbuild group in /web with 2 updates (#8282) web: bump the sentry group in /web with 1 update (#8281) web: bump @codemirror/lang-html from 6.4.7 to 6.4.8 in /web (#8283) core: bump bandit from 1.7.6 to 1.7.7 (#8285) core: bump selenium from 4.16.0 to 4.17.2 (#8284) core: bump github.com/go-openapi/runtime from 0.26.2 to 0.27.0 (#8287) core: bump github.com/google/uuid from 1.5.0 to 1.6.0 (#8286) website/docs: Improve example nginx reverse proxy config (#8160) translate: Updates for file web/xliff/en.xlf in zh_CN (#8274) ...

sentry · 2024-01-25T12:39:45Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ TypeError: Object of type UUID is not JSON serializable json.encoder in default View Issue

_{Did you find this useful? React with a 👍 or 👎}

* main: (76 commits) core: compile backend translations (#8311) translate: Updates for file web/xliff/en.xlf in zh-Hans (#8304) translate: Updates for file web/xliff/en.xlf in zh_CN (#8305) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8300) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8301) events: fix missing labels on prometheus metrics (#8309) core: bump goauthentik.io/api/v3 from 3.2023106.4 to 3.2023106.5 (#8302) web: bump the wdio group in /tests/wdio with 4 updates (#8303) web: restore test anchor tag (#8298) translate: Updates for file web/xliff/en.xlf in fr (#8296) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295) website: update wording (#8290) enterrpise: exclude inactive users from license (#8294) web: bump API Client version (#8292) core: compile backend translations (#8291) events: migrate SystemTasks to DB (#8159) web/admin: fix footer links not being parsed on settings page (#8289) root: fix system check warnings (#8277) web: bump API Client version (#8288) enterprise: add full audit log [AUTH-458] (#8177) ...

* main: (131 commits) web: provide a context for checking the status of the enterprise license (#8153) core: compile backend translations (#8311) translate: Updates for file web/xliff/en.xlf in zh-Hans (#8304) translate: Updates for file web/xliff/en.xlf in zh_CN (#8305) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8300) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8301) events: fix missing labels on prometheus metrics (#8309) core: bump goauthentik.io/api/v3 from 3.2023106.4 to 3.2023106.5 (#8302) web: bump the wdio group in /tests/wdio with 4 updates (#8303) web: restore test anchor tag (#8298) translate: Updates for file web/xliff/en.xlf in fr (#8296) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295) website: update wording (#8290) enterrpise: exclude inactive users from license (#8294) web: bump API Client version (#8292) core: compile backend translations (#8291) events: migrate SystemTasks to DB (#8159) web/admin: fix footer links not being parsed on settings page (#8289) root: fix system check warnings (#8277) web: bump API Client version (#8288) ...

* main: (119 commits) web: provide a context for checking the status of the enterprise license (#8153) core: compile backend translations (#8311) translate: Updates for file web/xliff/en.xlf in zh-Hans (#8304) translate: Updates for file web/xliff/en.xlf in zh_CN (#8305) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8300) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8301) events: fix missing labels on prometheus metrics (#8309) core: bump goauthentik.io/api/v3 from 3.2023106.4 to 3.2023106.5 (#8302) web: bump the wdio group in /tests/wdio with 4 updates (#8303) web: restore test anchor tag (#8298) translate: Updates for file web/xliff/en.xlf in fr (#8296) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295) website: update wording (#8290) enterrpise: exclude inactive users from license (#8294) web: bump API Client version (#8292) core: compile backend translations (#8291) events: migrate SystemTasks to DB (#8159) web/admin: fix footer links not being parsed on settings page (#8289) root: fix system check warnings (#8277) web: bump API Client version (#8288) ...

* main: (30 commits) web: clear out selecteds list after an API event to ensure a fresh copy of the policies-to-delete list (#8125) web: provide dual-list multiselect with pagination (#8004) web: provide a context for checking the status of the enterprise license (#8153) core: compile backend translations (#8311) translate: Updates for file web/xliff/en.xlf in zh-Hans (#8304) translate: Updates for file web/xliff/en.xlf in zh_CN (#8305) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8300) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8301) events: fix missing labels on prometheus metrics (#8309) core: bump goauthentik.io/api/v3 from 3.2023106.4 to 3.2023106.5 (#8302) web: bump the wdio group in /tests/wdio with 4 updates (#8303) web: restore test anchor tag (#8298) translate: Updates for file web/xliff/en.xlf in fr (#8296) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295) website: update wording (#8290) enterrpise: exclude inactive users from license (#8294) web: bump API Client version (#8292) core: compile backend translations (#8291) events: migrate SystemTasks to DB (#8159) web/admin: fix footer links not being parsed on settings page (#8289) ...

BeryJu requested review from a team as code owners January 13, 2024 21:49

BeryJu added 11 commits January 24, 2024 13:43

events: migrate system tasks to save in DB

0e62e75

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

prefill in app startup

6c7e34c

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

cleanup api

1682c05

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

update web

2a4fcb8

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

use string for status

b78c04f

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix enum

b89fbcc

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

save start and end directly in timestamp from default_timer()

670d918

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

improve metrics

04500b8

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

lint

b2a8a6c

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix tests

ec0d9ff

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

rename globally to system task

99f1204

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu force-pushed the events/migrate-tasks-db branch from 08ee66d to 99f1204 Compare January 24, 2024 12:46

recreate migrations, better denote anonymous user

c0ea169

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu force-pushed the events/migrate-tasks-db branch from c4d8f65 to c0ea169 Compare January 24, 2024 13:18

BeryJu added 3 commits January 24, 2024 14:18

events: lookup actual django app instead of using module path, fallba…

cef02d9

…ck to module path Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix logger call

c50a057

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix

c0e8350

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

kensternberg-authentik approved these changes Jan 24, 2024

View reviewed changes

BeryJu merged commit 96b2a1a into main Jan 24, 2024

BeryJu deleted the events/migrate-tasks-db branch January 24, 2024 16:23

ChandonPierre mentioned this pull request Aug 15, 2024

outpost_connection_discovery does not run on initial worker start-up #10933

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

events: migrate SystemTasks to DB#8159

events: migrate SystemTasks to DB#8159
BeryJu merged 15 commits intomainfrom
events/migrate-tasks-db

BeryJu commented Jan 13, 2024

Uh oh!

netlify bot commented Jan 13, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 13, 2024

Uh oh!

codecov bot commented Jan 13, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 14, 2024 •

edited

Loading

Uh oh!

kensternberg-authentik left a comment

Uh oh!

kensternberg-authentik Jan 24, 2024

Uh oh!

sentry bot commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

BeryJu commented Jan 13, 2024

Details

Checklist

Uh oh!

netlify bot commented Jan 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook canceled.

Uh oh!

github-actions bot commented Jan 13, 2024

authentik translations instructions

Uh oh!

codecov bot commented Jan 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kensternberg-authentik left a comment

Choose a reason for hiding this comment

Uh oh!

kensternberg-authentik Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

sentry bot commented Jan 25, 2024

Suspect Issues

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Jan 13, 2024 •

edited

Loading

codecov bot commented Jan 13, 2024 •

edited

Loading

github-actions bot commented Jan 14, 2024 •

edited

Loading