Skip to content

web/admin: fix prompt form and codemirror mode#7231

Merged
BeryJu merged 4 commits intomainfrom
web/admin/fix-extra-brace
Oct 19, 2023
Merged

web/admin: fix prompt form and codemirror mode#7231
BeryJu merged 4 commits intomainfrom
web/admin/fix-extra-brace

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 19, 2023

Details

image


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner October 19, 2023 21:07
@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 9777bb2
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6531a0544c231e000846c908
😎 Deploy Preview https://deploy-preview-7231--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4686796) 92.66% compared to head (9777bb2) 92.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7231      +/-   ##
==========================================
- Coverage   92.66%   92.65%   -0.02%     
==========================================
  Files         584      584              
  Lines       28766    28766              
==========================================
- Hits        26657    26654       -3     
- Misses       2109     2112       +3     
Flag Coverage Δ
e2e 51.08% <ø> (-0.02%) ⬇️
integration 26.07% <ø> (ø)
unit 89.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu changed the title web/admin: fix extra curly brace web/admin: fix prompt form and codemirror mode Oct 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-web-admin-fix-extra-brace-1697752061-9777bb2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-web-admin-fix-extra-brace-1697752061-9777bb2-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-web-admin-fix-extra-brace-1697752061-9777bb2

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-web-admin-fix-extra-brace-1697752061-9777bb2-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 41464ae into main Oct 19, 2023
@BeryJu BeryJu deleted the web/admin/fix-extra-brace branch October 19, 2023 21:53
kensternberg-authentik added a commit that referenced this pull request Oct 19, 2023
* main:
  web: isolate clipboard handling (#7229)
  web/flows: update flow background (#7232)
  web/admin: fix prompt form and codemirror mode (#7231)
kensternberg-authentik added a commit that referenced this pull request Oct 20, 2023
* main:
  web/flows: update flow background (#7232)
  web/admin: fix prompt form and codemirror mode (#7231)
  web/admin: decrease wizard hint padding (#7227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant