Skip to content

web/admin: decrease wizard hint padding#7227

Merged
BeryJu merged 1 commit intomainfrom
web/admin/adjust-hint-padding
Oct 19, 2023
Merged

web/admin: decrease wizard hint padding#7227
BeryJu merged 1 commit intomainfrom
web/admin/adjust-hint-padding

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 19, 2023

Details

REPLACE ME

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner October 19, 2023 12:54
@netlify
Copy link

netlify bot commented Oct 19, 2023 •
edited
Loading

✅ Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit f7e5999
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6531492d7a96a1000843db2b
😎 Deploy Preview https://deploy-preview-7227--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (34367a7) 48.40% compared to head (547ea81) 92.33%.
Report is 1 commits behind head on main.

❗ Current head 547ea81 differs from pull request most recent head f7e5999. Consider uploading reports for the commit f7e5999 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #7227       +/-   ##
===========================================
+ Coverage   48.40%   92.33%   +43.93%     
===========================================
  Files         584      584               
  Lines       28707    28707               
===========================================
+ Hits        13897    26508    +12611     
+ Misses      14810     2199    -12611
Flag Coverage Δ
e2e 50.36% <ø> (+3.59%) ⬆️
integration 26.12% <ø> (ø)
unit 89.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 413 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-web-admin-adjust-hint-padding-1697721049-547ea81
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-web-admin-adjust-hint-padding-1697721049-547ea81-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-web-admin-adjust-hint-padding-1697721049-547ea81

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-web-admin-adjust-hint-padding-1697721049-547ea81-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu
web/admin: decrease wizard hint padding
f7e5999 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the web/admin/adjust-hint-padding branch from 547ea81 to f7e5999 Compare October 19, 2023 15:20
@BeryJu BeryJu merged commit 4686796 into main Oct 19, 2023
@BeryJu BeryJu deleted the web/admin/adjust-hint-padding branch October 19, 2023 15:59
kensternberg-authentik added a commit that referenced this pull request Oct 20, 2023
@kensternberg-authentik
Merge branch 'main' into web/theme-controller-2
83338f8 
* main:
  web/flows: update flow background (#7232)
  web/admin: fix prompt form and codemirror mode (#7231)
  web/admin: decrease wizard hint padding (#7227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BeryJu