Skip to content

stages/invitation: fix mis-matched serializer class for invitation#7018

Merged
BeryJu merged 2 commits intomainfrom
stages/invitation/fix-incorrect-serializer
Oct 2, 2023
Merged

stages/invitation: fix mis-matched serializer class for invitation#7018
BeryJu merged 2 commits intomainfrom
stages/invitation/fix-incorrect-serializer

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Sep 29, 2023

Details

the invitation object has an incorrect serializer which caused some issues with the flow inspector


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner September 29, 2023 16:40
@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit f81b920
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/651a93636439e1000820dce5
😎 Deploy Preview https://deploy-preview-7018--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (17047da) 92.71% compared to head (f81b920) 92.25%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7018      +/-   ##
==========================================
- Coverage   92.71%   92.25%   -0.46%     
==========================================
  Files         567      567              
  Lines       27965    27969       +4     
==========================================
- Hits        25925    25800     -125     
- Misses       2040     2169     +129     
Flag Coverage Δ
e2e 49.42% <0.00%> (-1.70%) ⬇️
integration 26.26% <0.00%> (-<0.01%) ⬇️
unit 89.60% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...thentik/blueprints/tests/test_serializer_models.py 100.00% <100.00%> (ø)
authentik/stages/invitation/models.py 100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit 8c891b0 into main Oct 2, 2023
@BeryJu BeryJu deleted the stages/invitation/fix-incorrect-serializer branch October 2, 2023 10:26
kensternberg-authentik added a commit that referenced this pull request Oct 2, 2023
* main:
  web/admin: use <pre> for order field on bound elements (#7031)
  blueprints: fix mismatched user-login stage order (#7030)
  stages/email: rework email templates (#7029)
  website/docs: add notice for nginx ingress configuration requirement (#7027)
  translate: Updates for web/xliff/en.xlf in fr
  web: locales: rename fr_FR to fr to match transifex
  events: fix error when storing events with date/time/datetime/etc (#7028)
  stages/invitation: fix mis-matched serializer class for invitation (#7018)
  web: bump mermaid from 10.4.0 to 10.5.0 in /web (#7026)
  web: bump core-js from 3.32.2 to 3.33.0 in /web (#7020)
  core: bump webauthn from 1.10.1 to 1.11.0 (#7021)
  core: bump pylint from 2.17.6 to 2.17.7 (#7022)
  core: bump django-redis from 5.3.0 to 5.4.0 (#7023)
  core: bump packaging from 23.1 to 23.2 (#7024)
kensternberg-authentik added a commit that referenced this pull request Oct 2, 2023
* main: (23 commits)
  web/admin: use <pre> for order field on bound elements (#7031)
  blueprints: fix mismatched user-login stage order (#7030)
  stages/email: rework email templates (#7029)
  website/docs: add notice for nginx ingress configuration requirement (#7027)
  translate: Updates for web/xliff/en.xlf in fr
  web: locales: rename fr_FR to fr to match transifex
  events: fix error when storing events with date/time/datetime/etc (#7028)
  stages/invitation: fix mis-matched serializer class for invitation (#7018)
  web: bump mermaid from 10.4.0 to 10.5.0 in /web (#7026)
  web: bump core-js from 3.32.2 to 3.33.0 in /web (#7020)
  core: bump webauthn from 1.10.1 to 1.11.0 (#7021)
  core: bump pylint from 2.17.6 to 2.17.7 (#7022)
  core: bump django-redis from 5.3.0 to 5.4.0 (#7023)
  core: bump packaging from 23.1 to 23.2 (#7024)
  web/admin: invitation stage: default "continue without invitation" to false
  core: bump pydantic from 2.4.1 to 2.4.2 (#7014)
  website: bump postcss from 8.4.30 to 8.4.31 in /website (#7015)
  internal: fix redis session store (#7011)
  web: bump rollup from 3.29.3 to 3.29.4 in /web (#7009)
  core: bump github.com/prometheus/client_golang from 1.16.0 to 1.17.0 (#7007)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant