Skip to content

internal: fix redis session store#7011

Merged
BeryJu merged 1 commit intomainfrom
root/fix-go-redis-sessions
Sep 28, 2023
Merged

internal: fix redis session store#7011
BeryJu merged 1 commit intomainfrom
root/fix-go-redis-sessions

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Sep 28, 2023

Details

Fix redis sessions not being created currently


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner September 28, 2023 15:13
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 8e964eb
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6515981121a54700085fdccc

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8752148) 92.71% compared to head (8e964eb) 51.26%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7011       +/-   ##
===========================================
- Coverage   92.71%   51.26%   -41.45%     
===========================================
  Files         567      567               
  Lines       27965    27965               
===========================================
- Hits        25925    14333    -11592     
- Misses       2040    13632    +11592     
Flag Coverage Δ
e2e 49.51% <ø> (-1.61%) ⬇️
integration 26.27% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 390 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-fix-go-redis-sessions-1695914703-8e964eb
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-fix-go-redis-sessions-1695914703-8e964eb-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-fix-go-redis-sessions-1695914703-8e964eb

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-fix-go-redis-sessions-1695914703-8e964eb-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit efb2823 into main Sep 28, 2023
@BeryJu BeryJu deleted the root/fix-go-redis-sessions branch September 28, 2023 19:06
kensternberg-authentik added a commit that referenced this pull request Sep 29, 2023
* main: (50 commits)
  web/admin: invitation stage: default "continue without invitation" to false
  core: bump pydantic from 2.4.1 to 2.4.2 (#7014)
  website: bump postcss from 8.4.30 to 8.4.31 in /website (#7015)
  internal: fix redis session store (#7011)
  web: bump rollup from 3.29.3 to 3.29.4 in /web (#7009)
  core: bump github.com/prometheus/client_golang from 1.16.0 to 1.17.0 (#7007)
  web: bump the esbuild group in /web with 2 updates (#7005)
  website: bump react-tooltip from 5.21.4 to 5.21.5 in /website (#7006)
  core: bump github.com/redis/go-redis/v9 from 9.2.0 to 9.2.1 (#7008)
  root: fix missing /lifecycle in path
  website/blog: add info-block to blog about m2m (#7002)
  root: handle SIGHUP and SIGUSR2, healthcheck gunicorn (#6630)
  flows: stage_invalid() makes flow restart depending on invalid_response_action setting (#6780)
  core: bump psycopg from 3.1.11 to 3.1.12 (#6997)
  core: bump pydantic from 2.4.0 to 2.4.1 (#6998)
  web: bump the sentry group in /web with 2 updates (#6999)
  web: bump pyright from 1.1.328 to 1.1.329 in /web (#7000)
  website/blog: improved sentence (#6995)
  website/blog: fix missing link in m2m post (#6994)
  web/user: fix incorrect link to admin interface (#6993)
  ...
kensternberg-authentik added a commit that referenced this pull request Oct 2, 2023
* main: (23 commits)
  web/admin: use <pre> for order field on bound elements (#7031)
  blueprints: fix mismatched user-login stage order (#7030)
  stages/email: rework email templates (#7029)
  website/docs: add notice for nginx ingress configuration requirement (#7027)
  translate: Updates for web/xliff/en.xlf in fr
  web: locales: rename fr_FR to fr to match transifex
  events: fix error when storing events with date/time/datetime/etc (#7028)
  stages/invitation: fix mis-matched serializer class for invitation (#7018)
  web: bump mermaid from 10.4.0 to 10.5.0 in /web (#7026)
  web: bump core-js from 3.32.2 to 3.33.0 in /web (#7020)
  core: bump webauthn from 1.10.1 to 1.11.0 (#7021)
  core: bump pylint from 2.17.6 to 2.17.7 (#7022)
  core: bump django-redis from 5.3.0 to 5.4.0 (#7023)
  core: bump packaging from 23.1 to 23.2 (#7024)
  web/admin: invitation stage: default "continue without invitation" to false
  core: bump pydantic from 2.4.1 to 2.4.2 (#7014)
  website: bump postcss from 8.4.30 to 8.4.31 in /website (#7015)
  internal: fix redis session store (#7011)
  web: bump rollup from 3.29.3 to 3.29.4 in /web (#7009)
  core: bump github.com/prometheus/client_golang from 1.16.0 to 1.17.0 (#7007)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants