sources/ldap: made ldap_sync_single calls from ldap_sync_all asynchronous#6862
Merged
BeryJu merged 1 commit intogoauthentik:mainfrom Oct 16, 2023
Merged
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6862 +/- ##
===========================================
- Coverage 92.67% 52.17% -40.50%
===========================================
Files 565 565
Lines 27794 27794
===========================================
- Hits 25756 14499 -11257
- Misses 2038 13295 +11257
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
BeryJu
approved these changes
Sep 12, 2023
Member
BeryJu
left a comment
There was a problem hiding this comment.
Oh yeah nice catch, I didn't even realise that the code wasn't doing this
BeryJu
approved these changes
Oct 16, 2023
kensternberg-authentik
added a commit
that referenced
this pull request
Oct 16, 2023
* main: web: the return of pseudolocalization (#7190) rbac: revisions (#7188) website: bump @babel/traverse from 7.21.4 to 7.23.2 in /website (#7187) web: bump API Client version (#7186) core: Initial RBAC (#6806) lifecycle: re-fix system migrations (#7185) outposts: use channel groups instead of saving channel names (#7183) sources/ldap: made ldap_sync_single calls from ldap_sync_all asynchronous (#6862) website/docs: fix API OAuth token usage (#7159) web: bump rollup from 4.1.3 to 4.1.4 in /web (#7181) web: bump @formatjs/intl-listformat from 7.4.2 to 7.5.0 in /web (#7182) web: bump @rollup/plugin-replace from 5.0.3 to 5.0.4 in /web (#7177) web: bump the sentry group in /web with 2 updates (#7175) web: bump @rollup/plugin-commonjs from 25.0.5 to 25.0.7 in /web (#7178) web: bump yaml from 2.3.2 to 2.3.3 in /web (#7176) web: bump rollup from 4.0.2 to 4.1.3 in /web (#7179) web: bump the wdio group in /tests/wdio with 3 updates (#7180)
kensternberg-authentik
added a commit
that referenced
this pull request
Oct 17, 2023
* main: (23 commits) ci: test with postgres 16 translate: Updates for file web/xliff/en.xlf in fr (#7189) web: bump the esbuild group in /web with 2 updates (#7195) web: bump the eslint group in /tests/wdio with 2 updates (#7192) core: bump ruff from 0.0.292 to 0.1.0 (#7194) web: bump the eslint group in /web with 2 updates (#7193) web: the return of pseudolocalization (#7190) rbac: revisions (#7188) website: bump @babel/traverse from 7.21.4 to 7.23.2 in /website (#7187) web: bump API Client version (#7186) core: Initial RBAC (#6806) lifecycle: re-fix system migrations (#7185) outposts: use channel groups instead of saving channel names (#7183) sources/ldap: made ldap_sync_single calls from ldap_sync_all asynchronous (#6862) website/docs: fix API OAuth token usage (#7159) web: bump rollup from 4.1.3 to 4.1.4 in /web (#7181) web: bump @formatjs/intl-listformat from 7.4.2 to 7.5.0 in /web (#7182) web: bump @rollup/plugin-replace from 5.0.3 to 5.0.4 in /web (#7177) web: bump the sentry group in /web with 2 updates (#7175) web: bump @rollup/plugin-commonjs from 25.0.5 to 25.0.7 in /web (#7178) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrary to the commit message of d36574f, ldap_sync_all does not call ldap_sync_single asynchronously. This leads to timeout, if the ldap_sync_single calls take more than 10 minutes in total.
This change fixes the issue.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)