core: Initial RBAC by BeryJu · Pull Request #6806 · goauthentik/authentik

BeryJu · 2023-09-08T11:53:46Z

Details

Add an initial API and WebUI for RBAC (both for general permissions and per-object permissions)

Checklist

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)
The translation files have been updated (make i18n-extract)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

netlify · 2023-09-08T11:53:51Z

✅ Deploy Preview for authentik-storybook canceled.

Name	Link
🔨 Latest commit	`b73324d`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/652d1899a216bc00085e2d70

codecov · 2023-09-08T11:59:09Z

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (63a9cf2) 92.63% compared to head (b73324d) 92.69%.
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6806      +/-   ##
==========================================
+ Coverage   92.63%   92.69%   +0.05%     
==========================================
  Files         568      584      +16     
  Lines       28049    28674     +625     
==========================================
+ Hits        25983    26578     +595     
- Misses       2066     2096      +30

Flag	Coverage Δ
e2e	`51.17% <55.09%> (+0.03%)`	⬆️
integration	`26.04% <14.87%> (-0.30%)`	⬇️
unit	`89.65% <94.05%> (+0.09%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
authentik/admin/api/meta.py	`100.00% <100.00%> (ø)`
authentik/admin/api/metrics.py	`100.00% <100.00%> (ø)`
authentik/admin/api/system.py	`98.38% <100.00%> (ø)`
authentik/admin/api/tasks.py	`100.00% <100.00%> (ø)`
authentik/admin/api/workers.py	`100.00% <100.00%> (ø)`
authentik/api/authorization.py	`90.00% <100.00%> (ø)`
authentik/api/decorators.py	`100.00% <100.00%> (ø)`
authentik/api/pagination.py	`89.47% <100.00%> (+1.23%)`	⬆️
authentik/api/tests/test_viewsets.py	`100.00% <100.00%> (ø)`
authentik/blueprints/api.py	`85.93% <100.00%> (-0.22%)`	⬇️
... and 38 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

netlify · 2023-09-20T14:55:35Z

✅ Deploy Preview for authentik ready!

Name	Link
🔨 Latest commit	`3d7ab5f`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik/deploys/65296ca2d90cc00008a3f72e
😎 Deploy Preview	https://deploy-preview-6806--authentik.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 4 from production) Accessibility: 90 (no change from production) Best Practices: 100 (no change from production) SEO: 80 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2023-10-10T14:48:59Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-core-rbac-1697468800-b73324d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-core-rbac-1697468800-b73324d-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-core-rbac-1697468800-b73324d

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-core-rbac-1697468800-b73324d-arm64

Afterwards, run the upgrade commands from the latest release notes.

notion-workspace · 2023-10-11T15:32:32Z

Object-level RBAC

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

also improve error display on table Signed-off-by: Jens Langhammer <jens@goauthentik.io>

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* main: web: the return of pseudolocalization (#7190) rbac: revisions (#7188) website: bump @babel/traverse from 7.21.4 to 7.23.2 in /website (#7187) web: bump API Client version (#7186) core: Initial RBAC (#6806) lifecycle: re-fix system migrations (#7185) outposts: use channel groups instead of saving channel names (#7183) sources/ldap: made ldap_sync_single calls from ldap_sync_all asynchronous (#6862) website/docs: fix API OAuth token usage (#7159) web: bump rollup from 4.1.3 to 4.1.4 in /web (#7181) web: bump @formatjs/intl-listformat from 7.4.2 to 7.5.0 in /web (#7182) web: bump @rollup/plugin-replace from 5.0.3 to 5.0.4 in /web (#7177) web: bump the sentry group in /web with 2 updates (#7175) web: bump @rollup/plugin-commonjs from 25.0.5 to 25.0.7 in /web (#7178) web: bump yaml from 2.3.2 to 2.3.3 in /web (#7176) web: bump rollup from 4.0.2 to 4.1.3 in /web (#7179) web: bump the wdio group in /tests/wdio with 3 updates (#7180)

* main: (23 commits) ci: test with postgres 16 translate: Updates for file web/xliff/en.xlf in fr (#7189) web: bump the esbuild group in /web with 2 updates (#7195) web: bump the eslint group in /tests/wdio with 2 updates (#7192) core: bump ruff from 0.0.292 to 0.1.0 (#7194) web: bump the eslint group in /web with 2 updates (#7193) web: the return of pseudolocalization (#7190) rbac: revisions (#7188) website: bump @babel/traverse from 7.21.4 to 7.23.2 in /website (#7187) web: bump API Client version (#7186) core: Initial RBAC (#6806) lifecycle: re-fix system migrations (#7185) outposts: use channel groups instead of saving channel names (#7183) sources/ldap: made ldap_sync_single calls from ldap_sync_all asynchronous (#6862) website/docs: fix API OAuth token usage (#7159) web: bump rollup from 4.1.3 to 4.1.4 in /web (#7181) web: bump @formatjs/intl-listformat from 7.4.2 to 7.5.0 in /web (#7182) web: bump @rollup/plugin-replace from 5.0.3 to 5.0.4 in /web (#7177) web: bump the sentry group in /web with 2 updates (#7175) web: bump @rollup/plugin-commonjs from 25.0.5 to 25.0.7 in /web (#7178) ...

BeryJu force-pushed the core/rbac branch 2 times, most recently from b552fa0 to 0cedff5 Compare September 20, 2023 14:52

BeryJu force-pushed the core/rbac branch 3 times, most recently from 6a3a35c to 1d78d8c Compare September 20, 2023 15:15

BeryJu force-pushed the core/rbac branch 6 times, most recently from 8999bff to 5e08683 Compare October 9, 2023 17:52

BeryJu force-pushed the core/rbac branch 2 times, most recently from 3ffb7f5 to 47ce8a3 Compare October 10, 2023 12:41

BeryJu force-pushed the core/rbac branch from f1845b0 to 5275de4 Compare October 10, 2023 15:56

BeryJu marked this pull request as ready for review October 11, 2023 12:26

BeryJu requested review from a team as code owners October 11, 2023 12:26

BeryJu force-pushed the core/rbac branch 2 times, most recently from 1fb8cfe to 196746c Compare October 11, 2023 12:53

rissson added the deploy_me Deploy the PR changes on a test environment label Oct 11, 2023

BeryJu force-pushed the core/rbac branch 3 times, most recently from 9801020 to c643ba7 Compare October 12, 2023 17:34

rename consent permission

c130cff

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu added 21 commits October 13, 2023 18:10

only make delete bulk form expandable if usedBy is set

a7685b2

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

expand permission tables

c86593e

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add more things

a05fb82

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add user global permission table

64d73c0

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix lint

31bf250

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix tests' url names

2cef011

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add tests for assign perms

ed88cb2

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add unassign tests

7608d4f

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

rebuild permissions

23e18d4

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

prevent assigning/unassigning permissions to internal service accounts

f999608

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

only enable default api browser in debug

d5cef33

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix role object permissions showing duplicate

5307fcd

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix role link on role object permissions table

156ad55

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix object permission modal having duplicate close buttons

0ccd0d9

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

return error if user has no global perm and no object perms

9c1da16

also improve error display on table Signed-off-by: Jens Langhammer <jens@goauthentik.io>

small optimisation

c434c16

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

optimise even more

30630eb

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

update locale

bcbb1cf

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add system permission for non-object permissions

c4b8914

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

allow access to admin interface based on perm

99155c5

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

clean

3d7ab5f

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu force-pushed the core/rbac branch from c643ba7 to 3d7ab5f Compare October 13, 2023 16:13

don't exclude base models

b73324d

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu merged commit e28babb into main Oct 16, 2023

BeryJu deleted the core/rbac branch October 16, 2023 15:31

This was referenced Mar 28, 2024

RBAC #5451

Closed

Is distributed administration possible ? #2673

Closed

Is it possible for non super-users to be granted access to list users and some attributes #3511

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

core: Initial RBAC#6806

core: Initial RBAC#6806
BeryJu merged 78 commits intomainfrom
core/rbac

BeryJu commented Sep 8, 2023 •

edited

Loading

Uh oh!

netlify bot commented Sep 8, 2023 •

edited

Loading

Uh oh!

codecov bot commented Sep 8, 2023 •

edited

Loading

Uh oh!

netlify bot commented Sep 20, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Oct 10, 2023 •

edited

Loading

Uh oh!

notion-workspace bot commented Oct 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

BeryJu commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Checklist

Uh oh!

netlify bot commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook canceled.

Uh oh!

codecov bot commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

netlify bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik ready!

Uh oh!

github-actions bot commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

notion-workspace bot commented Oct 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BeryJu commented Sep 8, 2023 •

edited

Loading

netlify bot commented Sep 8, 2023 •

edited

Loading

codecov bot commented Sep 8, 2023 •

edited

Loading

netlify bot commented Sep 20, 2023 •

edited

Loading

github-actions bot commented Oct 10, 2023 •

edited

Loading