Skip to content

blueprints: prevent duplicate password stage in default flow when using combined identification stage#6432

Merged
BeryJu merged 1 commit intomainfrom
blueprints/fix-default-duplicate-password-stage
Jul 31, 2023
Merged

blueprints: prevent duplicate password stage in default flow when using combined identification stage#6432
BeryJu merged 1 commit intomainfrom
blueprints/fix-default-duplicate-password-stage

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 31, 2023

Details

closes #5407

Adds a policy that checks if the user has already been authenticated (explicitly only checks password authentication) and skips the password stage that is bound by default


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

…ng combined identification stage

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner July 31, 2023 11:09
@BeryJu BeryJu requested review from smusali and removed request for a team July 31, 2023 11:09
@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 4b5e7f9
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64c79659e8604800087334da

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14% ⚠️

Comparison is base (1b12c90) 92.49% compared to head (4b5e7f9) 92.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6432      +/-   ##
==========================================
- Coverage   92.49%   92.34%   -0.14%     
==========================================
  Files         561      561              
  Lines       27053    27053              
==========================================
- Hits        25019    24980      -39     
- Misses       2034     2073      +39     
Flag Coverage Δ
e2e 50.85% <ø> (-0.73%) ⬇️
integration 26.51% <ø> (ø)
unit 89.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 5139656 into main Jul 31, 2023
@BeryJu BeryJu deleted the blueprints/fix-default-duplicate-password-stage branch July 31, 2023 11:42
kensternberg-authentik added a commit that referenced this pull request Aug 7, 2023
* main:
  blueprints: prevent duplicate password stage in default flow when using combined identification stage (#6432)
  website/integrations: cite better (#6431)
  root: add generated Source docs (#5323)
  website/docs: add architecture and persistence (#6250)
  core: bump paramiko from 3.2.0 to 3.3.1 (#6428)
  website: fix sidebar sizing (#6430)
  ci: update dependabot labels (#6423)
  website: fix sidebar layout (#6421)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default-authentication-flow should ignore the password stage if "Password stage" is selected in default-authentication-identification

1 participant