Skip to content

website: fix sidebar layout#6421

Merged
BeryJu merged 2 commits intomainfrom
website/fix-sidebar-layout
Jul 29, 2023
Merged

website: fix sidebar layout#6421
BeryJu merged 2 commits intomainfrom
website/fix-sidebar-layout

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 29, 2023

the changed layout worked in development, because I relied on the auto-generated react css class names, and forgot that those get minified in production

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

BeryJu added 2 commits July 29, 2023 17:42
the changed layout worked in development, because I relied on the auto-generated react css class names, and forgot that those get minified in production

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner July 29, 2023 15:46
@BeryJu BeryJu requested review from smusali and removed request for a team July 29, 2023 15:46
@netlify
Copy link

netlify bot commented Jul 29, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 08405cc
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64c534645aa0da0008662ca0

@netlify
Copy link

netlify bot commented Jul 29, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 08405cc
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/64c534645d1c5600084d2c5c
😎 Deploy Preview https://deploy-preview-6421--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ac7eb6) 92.46% compared to head (08405cc) 92.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6421   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files         561      561           
  Lines       27053    27053           
=======================================
  Hits        25012    25012           
  Misses       2041     2041           
Flag Coverage Δ
e2e 51.54% <ø> (-0.01%) ⬇️
integration 26.51% <ø> (ø)
unit 89.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-website-fix-sidebar-layout-1690646213-08405cc
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-website-fix-sidebar-layout-1690646213-08405cc-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-website-fix-sidebar-layout-1690646213-08405cc

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-website-fix-sidebar-layout-1690646213-08405cc-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 530ac43 into main Jul 29, 2023
@BeryJu BeryJu deleted the website/fix-sidebar-layout branch July 29, 2023 16:55
kensternberg-authentik added a commit that referenced this pull request Aug 7, 2023
* main:
  blueprints: prevent duplicate password stage in default flow when using combined identification stage (#6432)
  website/integrations: cite better (#6431)
  root: add generated Source docs (#5323)
  website/docs: add architecture and persistence (#6250)
  core: bump paramiko from 3.2.0 to 3.3.1 (#6428)
  website: fix sidebar sizing (#6430)
  ci: update dependabot labels (#6423)
  website: fix sidebar layout (#6421)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant