providers/proxy: preserve URL-encoded path characters in redirect#20476
Merged
BeryJu merged 1 commit intogoauthentik:mainfrom Feb 23, 2026
Merged
Conversation
Use r.URL.EscapedPath() instead of r.URL.Path when building the redirect URL in redirectToStart(). The decoded Path field converts %2F to /, which url.JoinPath then collapses via path.Clean, stripping encoded slashes from the URL. EscapedPath() preserves the original encoding, fixing 301 redirects that break apps like RabbitMQ which use %2F in their API paths.
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
BeryJu
approved these changes
Feb 23, 2026
dominic-r
approved these changes
Feb 23, 2026
Contributor
|
🍒 Cherry-pick to |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20476 +/- ##
==========================================
- Coverage 93.28% 93.25% -0.03%
==========================================
Files 981 981
Lines 55186 55276 +90
==========================================
+ Hits 51479 51549 +70
- Misses 3707 3727 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BeryJu
pushed a commit
that referenced
this pull request
Feb 23, 2026
…erry-pick #20476 to version-2026.2) (#20482) providers/proxy: preserve URL-encoded path characters in redirect (#20476) Use r.URL.EscapedPath() instead of r.URL.Path when building the redirect URL in redirectToStart(). The decoded Path field converts %2F to /, which url.JoinPath then collapses via path.Clean, stripping encoded slashes from the URL. EscapedPath() preserves the original encoding, fixing 301 redirects that break apps like RabbitMQ which use %2F in their API paths. Co-authored-by: Brolywood <44068132+Brolywood@users.noreply.github.com>
kensternberg-authentik
added a commit
that referenced
this pull request
Feb 24, 2026
* main: (104 commits) sources/saml: improve exception handling for saml response parsing (#20125) web/flow: separate flow inspector lifecycle from flow executor lifecycle (#20063) web/maintenance: no unknown attributes part 2 (#19014) website/docs: add info about make install and recovery key (#20447) web: bump ajv from 6.12.6 to 6.14.0 in /web (#20479) providers/proxy: preserve URL-encoded path characters in redirect (#20476) policies: measure policy process from manager (#20477) enterprise: monkey patch pyjwt to accept mismatching key (#20402) enterprise/lifecycle: use datetime instead of date to track review cycles (#20283) root: run `npm i` with `npm@11.10.1` in all subdirectories (#20471) providers/oauth2: device code flow client id via auth header (#20457) core: bump goauthentik/fips-debian from `4419749` to `d6def0a` in /lifecycle/container (#20467) core: bump goauthentik/fips-python from `d973c46` to `bccefee` in /lifecycle/container (#20466) core, web: bump ajv from 6.12.6 to 6.14.0 in /packages/prettier-config (#20462) ci: bump and fix daily (#20461) website/integrations: fix Vaultwarden SSO_SCOPES syntax (#20459) stages/user_login: log correct user when session binding is broken (#20094) web/flow: generate a single API object for network transactions and use it for the lifetime of the FlowExecutor (#20030) web/flow: refactor flow executor so component selection is in an easy-to-maintain table (#19999) website/integrations: gatus: fix config block (#20446) ...
kensternberg-authentik
added a commit
that referenced
this pull request
Feb 25, 2026
…/soc-captchas-and-webauthn * web/flow/20261-tidy-identification-stage: (107 commits) Added some visibility keys, as per @GirlBossRush sources/saml: improve exception handling for saml response parsing (#20125) web/flow: separate flow inspector lifecycle from flow executor lifecycle (#20063) web/maintenance: no unknown attributes part 2 (#19014) website/docs: add info about make install and recovery key (#20447) web: bump ajv from 6.12.6 to 6.14.0 in /web (#20479) providers/proxy: preserve URL-encoded path characters in redirect (#20476) Weird merge bug: same function appeared twice. policies: measure policy process from manager (#20477) enterprise: monkey patch pyjwt to accept mismatching key (#20402) enterprise/lifecycle: use datetime instead of date to track review cycles (#20283) root: run `npm i` with `npm@11.10.1` in all subdirectories (#20471) providers/oauth2: device code flow client id via auth header (#20457) core: bump goauthentik/fips-debian from `4419749` to `d6def0a` in /lifecycle/container (#20467) core: bump goauthentik/fips-python from `d973c46` to `bccefee` in /lifecycle/container (#20466) core, web: bump ajv from 6.12.6 to 6.14.0 in /packages/prettier-config (#20462) ci: bump and fix daily (#20461) website/integrations: fix Vaultwarden SSO_SCOPES syntax (#20459) stages/user_login: log correct user when session binding is broken (#20094) web/flow: generate a single API object for network transactions and use it for the lifetime of the FlowExecutor (#20030) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
r.URL.EscapedPath()instead ofr.URL.PathinredirectToStart()to preserve URL-encoded characters like%2Fr.URL.Pathreturns the decoded path, converting%2Fto/, whichurl.JoinPaththen collapses viapath.Clean, stripping encoded slashes from the redirect URLEscapedPath()preserves the original encoding while remaining backward compatible for paths without encoded charactersFixes #12602
Test plan
TestRedirectToStart_Proxy_EncodedSlashtest case verifying%2Fis preserved in both the redirect URL and session redirect valueTestRedirectToStart_*tests continue to passTestProxy_Redirect*tests continue to passTestCheckRedirectParam_*tests continue to pass