enterprise/lifecycle: use datetime instead of date to track review cycles#20283
Merged
gergosimonyi merged 7 commits intogoauthentik:mainfrom Feb 23, 2026
Merged
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20283 +/- ##
==========================================
- Coverage 93.28% 93.25% -0.04%
==========================================
Files 981 981
Lines 55186 55272 +86
==========================================
+ Hits 51479 51542 +63
- Misses 3707 3730 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GirlBossRush
approved these changes
Feb 14, 2026
BeryJu
reviewed
Feb 19, 2026
Co-authored-by: Jens L. <jens@beryju.org> Signed-off-by: Alexander Tereshkin <96586+atereshkin@users.noreply.github.com>
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
gergosimonyi
approved these changes
Feb 23, 2026
authentik-automation bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
…cles (#20283) * enterprise/lifecycle: use datetime instead of date to track review cycles (fix for #20265) * Update authentik/enterprise/lifecycle/api/iterations.py Co-authored-by: Jens L. <jens@beryju.org> Signed-off-by: Alexander Tereshkin <96586+atereshkin@users.noreply.github.com> * enterprise/lifecycle: replace extend_schema_field with type annotations --------- Signed-off-by: Alexander Tereshkin <96586+atereshkin@users.noreply.github.com> Co-authored-by: Simonyi Gergő <28359278+gergosimonyi@users.noreply.github.com> Co-authored-by: Jens L. <jens@beryju.org>
Contributor
|
🍒 Cherry-pick to |
gergosimonyi
added a commit
that referenced
this pull request
Feb 23, 2026
…cles (cherry-pick #20283 to version-2026.2) (#20473) enterprise/lifecycle: use datetime instead of date to track review cycles (#20283) * enterprise/lifecycle: use datetime instead of date to track review cycles (fix for #20265) * Update authentik/enterprise/lifecycle/api/iterations.py * enterprise/lifecycle: replace extend_schema_field with type annotations --------- Signed-off-by: Alexander Tereshkin <96586+atereshkin@users.noreply.github.com> Co-authored-by: Alexander Tereshkin <96586+atereshkin@users.noreply.github.com> Co-authored-by: Simonyi Gergő <28359278+gergosimonyi@users.noreply.github.com> Co-authored-by: Jens L. <jens@beryju.org>
kensternberg-authentik
added a commit
that referenced
this pull request
Feb 23, 2026
* main: enterprise: monkey patch pyjwt to accept mismatching key (#20402) enterprise/lifecycle: use datetime instead of date to track review cycles (#20283) root: run `npm i` with `npm@11.10.1` in all subdirectories (#20471) providers/oauth2: device code flow client id via auth header (#20457) core: bump goauthentik/fips-debian from `4419749` to `d6def0a` in /lifecycle/container (#20467) core: bump goauthentik/fips-python from `d973c46` to `bccefee` in /lifecycle/container (#20466) core, web: bump ajv from 6.12.6 to 6.14.0 in /packages/prettier-config (#20462) ci: bump and fix daily (#20461) website/integrations: fix Vaultwarden SSO_SCOPES syntax (#20459) stages/user_login: log correct user when session binding is broken (#20094)
kensternberg-authentik
added a commit
that referenced
this pull request
Feb 23, 2026
* main: (167 commits) enterprise: monkey patch pyjwt to accept mismatching key (#20402) enterprise/lifecycle: use datetime instead of date to track review cycles (#20283) root: run `npm i` with `npm@11.10.1` in all subdirectories (#20471) providers/oauth2: device code flow client id via auth header (#20457) core: bump goauthentik/fips-debian from `4419749` to `d6def0a` in /lifecycle/container (#20467) core: bump goauthentik/fips-python from `d973c46` to `bccefee` in /lifecycle/container (#20466) core, web: bump ajv from 6.12.6 to 6.14.0 in /packages/prettier-config (#20462) ci: bump and fix daily (#20461) website/integrations: fix Vaultwarden SSO_SCOPES syntax (#20459) stages/user_login: log correct user when session binding is broken (#20094) web/flow: generate a single API object for network transactions and use it for the lifetime of the FlowExecutor (#20030) web/flow: refactor flow executor so component selection is in an easy-to-maintain table (#19999) website/integrations: gatus: fix config block (#20446) core: bump msgraph-sdk from 1.54.0 to 1.55.0 (#20432) core: bump aws-cdk-lib from 2.238.0 to 2.239.0 (#20434) core: bump constructs from 10.5.0 to 10.5.1 (#20433) core: bump goauthentik/fips-python from `c272691` to `d973c46` in /lifecycle/container (#20437) core: bump goauthentik/fips-debian from `b0917af` to `4419749` in /lifecycle/container (#20438) web/admin/bugfix: Edit Stage not working. Invoking IdentificationStageForm not working (#20429) core: bump ruff from 0.15.1 to 0.15.2 (#20435) ...
kensternberg-authentik
added a commit
that referenced
this pull request
Feb 24, 2026
* main: (104 commits) sources/saml: improve exception handling for saml response parsing (#20125) web/flow: separate flow inspector lifecycle from flow executor lifecycle (#20063) web/maintenance: no unknown attributes part 2 (#19014) website/docs: add info about make install and recovery key (#20447) web: bump ajv from 6.12.6 to 6.14.0 in /web (#20479) providers/proxy: preserve URL-encoded path characters in redirect (#20476) policies: measure policy process from manager (#20477) enterprise: monkey patch pyjwt to accept mismatching key (#20402) enterprise/lifecycle: use datetime instead of date to track review cycles (#20283) root: run `npm i` with `npm@11.10.1` in all subdirectories (#20471) providers/oauth2: device code flow client id via auth header (#20457) core: bump goauthentik/fips-debian from `4419749` to `d6def0a` in /lifecycle/container (#20467) core: bump goauthentik/fips-python from `d973c46` to `bccefee` in /lifecycle/container (#20466) core, web: bump ajv from 6.12.6 to 6.14.0 in /packages/prettier-config (#20462) ci: bump and fix daily (#20461) website/integrations: fix Vaultwarden SSO_SCOPES syntax (#20459) stages/user_login: log correct user when session binding is broken (#20094) web/flow: generate a single API object for network transactions and use it for the lifetime of the FlowExecutor (#20030) web/flow: refactor flow executor so component selection is in an easy-to-maintain table (#19999) website/integrations: gatus: fix config block (#20446) ...
kensternberg-authentik
added a commit
that referenced
this pull request
Feb 25, 2026
…/soc-captchas-and-webauthn * web/flow/20261-tidy-identification-stage: (107 commits) Added some visibility keys, as per @GirlBossRush sources/saml: improve exception handling for saml response parsing (#20125) web/flow: separate flow inspector lifecycle from flow executor lifecycle (#20063) web/maintenance: no unknown attributes part 2 (#19014) website/docs: add info about make install and recovery key (#20447) web: bump ajv from 6.12.6 to 6.14.0 in /web (#20479) providers/proxy: preserve URL-encoded path characters in redirect (#20476) Weird merge bug: same function appeared twice. policies: measure policy process from manager (#20477) enterprise: monkey patch pyjwt to accept mismatching key (#20402) enterprise/lifecycle: use datetime instead of date to track review cycles (#20283) root: run `npm i` with `npm@11.10.1` in all subdirectories (#20471) providers/oauth2: device code flow client id via auth header (#20457) core: bump goauthentik/fips-debian from `4419749` to `d6def0a` in /lifecycle/container (#20467) core: bump goauthentik/fips-python from `d973c46` to `bccefee` in /lifecycle/container (#20466) core, web: bump ajv from 6.12.6 to 6.14.0 in /packages/prettier-config (#20462) ci: bump and fix daily (#20461) website/integrations: fix Vaultwarden SSO_SCOPES syntax (#20459) stages/user_login: log correct user when session binding is broken (#20094) web/flow: generate a single API object for network transactions and use it for the lifetime of the FlowExecutor (#20030) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This fixes the incorrect review Opened date display for new reviews described in #20265
The root cause of the problem was the use of a DateField for storing review opening date which made it ambiguous across time zones (which combined with some questionable behavior of openapi-generator led to incorrect to incorrect dates in the UI). The fix is to switch to a DateTimeField. Extra precaution had to be taken because the task that applies lifecycle rules runs once a day and direct comparison of datetimes could lead to 24h delays in opening new reviews and reviews going overdue because of millisecond fluctuation in the task execution time.
Checklist
ak test authentik/)make lint-fix)make gen-build)