Skip to content

website/docs: correct reference to overriden S3 variable#20156

Merged
dominic-r merged 1 commit intogoauthentik:mainfrom
tacerus:s3-docs
Feb 11, 2026
Merged

website/docs: correct reference to overriden S3 variable#20156
dominic-r merged 1 commit intogoauthentik:mainfrom
tacerus:s3-docs

Conversation

@tacerus
Copy link
Contributor

@tacerus tacerus commented Feb 10, 2026

Details

The duplicate reference to AUTHENTIK_STORAGE__FILE__[...] in https://docs.goauthentik.io/install-config/configuration/#media-storage-settings seemed odd.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@tacerus tacerus requested a review from a team as a code owner February 10, 2026 20:35
@netlify
Copy link

netlify bot commented Feb 10, 2026

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit d12500a
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/698b969b13ee7f0008f95a51
😎 Deploy Preview https://deploy-preview-20156--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 10, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit d12500a
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/698b969bd5701f00085bb329
😎 Deploy Preview https://deploy-preview-20156--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tacerus
Copy link
Contributor Author

tacerus commented Feb 10, 2026

On a related note, I think the paragraph below

These settings affect where media files are stored. Those files include applications and sources icons. By default, they use the same storage settings as the main storage configuration. S3 storage is also supported.

is slightly confusing too given its only below the "old" S3 variable which overrides a different one, and it partially repeating what's already written earlier.

@dominic-r dominic-r changed the title docs: correct reference to overriden S3 variable website/docs: correct reference to overriden S3 variable Feb 10, 2026
Fixes: c30d1a4 ("files: rework (goauthentik#17535)")
Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.28%. Comparing base (0356a30) to head (dfa2a15).
⚠️ Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20156      +/-   ##
==========================================
- Coverage   93.29%   93.28%   -0.02%     
==========================================
  Files         978      978              
  Lines       54544    54544              
==========================================
- Hits        50889    50880       -9     
- Misses       3655     3664       +9     
Flag Coverage Δ
conformance 37.75% <ø> (+<0.01%) ⬆️
e2e 43.62% <ø> (-0.01%) ⬇️
integration 22.52% <ø> (-0.05%) ⬇️
unit 91.51% <ø> (+<0.01%) ⬆️
unit-migrate 91.55% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominic-r dominic-r enabled auto-merge (squash) February 11, 2026 15:27
@dominic-r dominic-r merged commit 37432f4 into goauthentik:main Feb 11, 2026
101 checks passed
kensternberg-authentik added a commit that referenced this pull request Feb 12, 2026
* main: (59 commits)
  website/docs: 2025.12.4 release notes (#20226)
  website/docs: 2025.10.4 release notes (#20242)
  security: CVE-2026-25748 (#20240)
  security: CVE-2026-25922 (#20241)
  security: CVE-2026-25227 (#20239)
  ci: fix release testing (#20207)
  core: Apply CSpell corrections. (#20191)
  core: bump goauthentik.io/api/v3 to 3.2026.5.0-rc1-1770842608 (#20213)
  core, web: update translations (#20215)
  core: bump library/node from 25.6.0-trixie to 25.6.1-trixie in /website (#20220)
  core: bump google-api-python-client from 2.189.0 to 2.190.0 (#20217)
  core: bump webauthn from 2.7.0 to 2.7.1 (#20218)
  ci: bump docker/build-push-action from 6.18.0 to 6.19.1 (#20221)
  website/integrations: Update Komga instructions to add "email_verified" attribute to "email" claim. (#20135)
  website: Apply CSpell corrections. (#20189)
  providers/saml: send logoutResponse on sp-init logout (#17691)
  website/docs: ssf: update SSF documentation (#20195)
  website/docs: draft of new WS-Fed provider docs  (#20091)
  website/docs: add email verification scope doc (#20141)
  website/docs: correct reference to overriden S3 variable (#20156)
  ...
kensternberg-authentik added a commit that referenced this pull request Feb 12, 2026
* main: (59 commits)
  website/docs: 2025.12.4 release notes (#20226)
  website/docs: 2025.10.4 release notes (#20242)
  security: CVE-2026-25748 (#20240)
  security: CVE-2026-25922 (#20241)
  security: CVE-2026-25227 (#20239)
  ci: fix release testing (#20207)
  core: Apply CSpell corrections. (#20191)
  core: bump goauthentik.io/api/v3 to 3.2026.5.0-rc1-1770842608 (#20213)
  core, web: update translations (#20215)
  core: bump library/node from 25.6.0-trixie to 25.6.1-trixie in /website (#20220)
  core: bump google-api-python-client from 2.189.0 to 2.190.0 (#20217)
  core: bump webauthn from 2.7.0 to 2.7.1 (#20218)
  ci: bump docker/build-push-action from 6.18.0 to 6.19.1 (#20221)
  website/integrations: Update Komga instructions to add "email_verified" attribute to "email" claim. (#20135)
  website: Apply CSpell corrections. (#20189)
  providers/saml: send logoutResponse on sp-init logout (#17691)
  website/docs: ssf: update SSF documentation (#20195)
  website/docs: draft of new WS-Fed provider docs  (#20091)
  website/docs: add email verification scope doc (#20141)
  website/docs: correct reference to overriden S3 variable (#20156)
  ...
@gergosimonyi gergosimonyi added the backport/version-2026.2 Add this label to PRs to backport changes to version-2026.2 label Feb 18, 2026
authentik-automation bot pushed a commit that referenced this pull request Feb 18, 2026
docs: correct reference to overriden S3 variable

Fixes: c30d1a4 ("files: rework (#17535)")

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
@authentik-automation
Copy link
Contributor

🍒 Cherry-pick to version-2026.2 created: #20378

dewi-tik pushed a commit that referenced this pull request Feb 18, 2026
…20156 to version-2026.2) (#20378)

website/docs: correct reference to overriden S3 variable (#20156)

docs: correct reference to overriden S3 variable

Fixes: c30d1a4 ("files: rework (#17535)")

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
Co-authored-by: Georg <georg@lysergic.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/version-2026.2 Add this label to PRs to backport changes to version-2026.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants