Skip to content

files: rework#17535

Merged
rissson merged 139 commits intomainfrom
files
Dec 2, 2025
Merged

files: rework#17535
rissson merged 139 commits intomainfrom
files

Conversation

@rissson
Copy link
Member

@rissson rissson commented Oct 18, 2025

TODO:

  • frontend
  • authz for file backend
  • docs
  • used by endpoint works, but frontend doesn't show stuff, idk why

@rissson rissson self-assigned this Oct 18, 2025
@netlify
Copy link

netlify bot commented Oct 18, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit d316944
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/692f0d70b42cfd0008247c50

@netlify
Copy link

netlify bot commented Oct 18, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit d316944
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/692f0d6fb42cfd0008247c4b

@netlify
Copy link

netlify bot commented Oct 18, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit d316944
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/692f0d7092caf40008731f6d

@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 94.62572% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.15%. Comparing base (a46c5e5) to head (d316944).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/admin/files/api.py 76.15% 31 Missing ⚠️
authentik/admin/files/tests/utils.py 90.80% 8 Missing ⚠️
authentik/admin/files/manager.py 91.54% 6 Missing ⚠️
authentik/admin/files/backends/s3.py 94.84% 5 Missing ⚠️
authentik/admin/files/backends/static.py 90.62% 3 Missing ⚠️
authentik/core/models.py 71.42% 2 Missing ⚠️
authentik/lib/utils/dict.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17535      +/-   ##
==========================================
+ Coverage   93.03%   93.15%   +0.11%     
==========================================
  Files         911      928      +17     
  Lines       49848    50615     +767     
==========================================
+ Hits        46376    47148     +772     
+ Misses       3472     3467       -5     
Flag Coverage Δ
e2e 44.97% <28.59%> (-0.28%) ⬇️
integration 22.85% <19.57%> (-0.03%) ⬇️
unit 91.34% <94.62%> (+0.13%) ⬆️
unit-migrate 91.39% <94.62%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson moved this to Todo in authentik Core Oct 24, 2025
@dominic-r dominic-r linked an issue Oct 27, 2025 that may be closed by this pull request
@rissson rissson mentioned this pull request Oct 28, 2025
@dominic-r dominic-r self-assigned this Nov 4, 2025
@dominic-r dominic-r added this to the Release 2025.12 milestone Nov 4, 2025
@dominic-r
Copy link
Member

todo: events

rissson and others added 8 commits November 13, 2025 20:11
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

wip

wip

wip

argh

rmdir

wip

wip

wip
…en refactor stuff before tests. but THE MEDIA RENDER NOW
1. Log in to authentik as an administrator and open the authentik Admin interface.
2. Navigate to **Customization** > **Files**.

Here you can upload a new file, delete a file, and search for a file that you already uploaded.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't really fit with the rest of the doc

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

Image files are used in authentik to add a logo to new applications that you add, or to a new source, and for defining the ["branded" look](../sys-mgmt/brands.md#branding-settings) of the authentik interface, with your company's logo and title, a favicon, or a background image for the flows.

authentik provides a central place for storing all such files, the `authentik/data/media/public` directory. By default, these files are stored in authentik's PostgreSQL database.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
authentik provides a central place for storing all such files, the `authentik/data/media/public` directory. By default, these files are stored in authentik's PostgreSQL database.
authentik provides a central place for storing all such files. By default files are stored on disk, but S3 storage can also be configured.```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a very good reason not to, I'd like to specify the directory. It helped me a lot to know where to look for images. Thoughts @rissson ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a configurable option. So let's link to that option if you want. (AUTHENTIK_STORAGE__FILE__PATH)

@rissson rissson requested a review from tanberry December 2, 2025 13:26
tanberry and others added 3 commits December 2, 2025 09:48
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson moved this from In Progress to Needs review in authentik Core Dec 2, 2025
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature, @dominic-r and @rissson !!


Image files are used in authentik to add a logo to new applications that you add, or to a new source, and for defining the ["branded" look](../sys-mgmt/brands.md#branding-settings) of the authentik interface, with your company's logo and title, a favicon, or a background image for the flows.

authentik provides a central place for storing all such files, the `authentik/data/media/public` directory. By default, these files are stored in authentik's PostgreSQL database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a very good reason not to, I'd like to specify the directory. It helped me a lot to know where to look for images. Thoughts @rissson ?

@rissson rissson requested a review from BeryJu December 2, 2025 16:48
@github-project-automation github-project-automation bot moved this from Needs review to In Progress in authentik Core Dec 2, 2025
@rissson rissson merged commit c30d1a4 into main Dec 2, 2025
98 of 99 checks passed
@rissson rissson deleted the files branch December 2, 2025 17:01
@github-project-automation github-project-automation bot moved this from In Progress to Done in authentik Core Dec 2, 2025
tacerus added a commit to tacerus/authentik that referenced this pull request Feb 10, 2026
Fixes: c30d1a4 ("files: rework (goauthentik#17535)")
Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
dominic-r pushed a commit to tacerus/authentik that referenced this pull request Feb 11, 2026
Fixes: c30d1a4 ("files: rework (goauthentik#17535)")
Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
dominic-r pushed a commit that referenced this pull request Feb 11, 2026
docs: correct reference to overriden S3 variable

Fixes: c30d1a4 ("files: rework (#17535)")

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
authentik-automation bot pushed a commit that referenced this pull request Feb 18, 2026
docs: correct reference to overriden S3 variable

Fixes: c30d1a4 ("files: rework (#17535)")

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
dewi-tik pushed a commit that referenced this pull request Feb 18, 2026
…20156 to version-2026.2) (#20378)

website/docs: correct reference to overriden S3 variable (#20156)

docs: correct reference to overriden S3 variable

Fixes: c30d1a4 ("files: rework (#17535)")

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
Co-authored-by: Georg <georg@lysergic.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend deploy_me Deploy the PR changes on a test environment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

files: rework

6 participants