web: Lit Development Mode, performance fixes.#19825
Merged
GirlBossRush merged 1 commit intomainfrom Jan 30, 2026
Merged
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
602f997 to
5db9597
Compare
GirlBossRush
commented
Jan 29, 2026
Comment on lines
48
to
+57
| @@ -54,7 +54,7 @@ | |||
| * a dark sidebar on light themes. Only minor changes are needed for the dark mode. | |||
| * @see PatternFly's nav.css for reference: | |||
| */ | |||
| :host([theme="light"]) .pf-c-nav { | |||
| :host(:not([theme="dark"])) .pf-c-nav { | |||
Contributor
Author
There was a problem hiding this comment.
AFAICT this was the last remaining check for a light theme. The path to removing all the theme attribute style overrides will be awhile, but this marks one fewer dependency
GirlBossRush
commented
Jan 29, 2026
Comment on lines
+77
to
+79
| public get activeWhen(): RegExp[] { | ||
| return this.activeMatchers; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Fixes Lit warning about missing getter.
GirlBossRush
commented
Jan 29, 2026
Comment on lines
+81
to
+88
| public override connectedCallback(): void { | ||
| super.connectedCallback(); | ||
| this.synchronize(); | ||
| } | ||
|
|
||
| public override disconnectedCallback(): void { | ||
| super.disconnectedCallback(); | ||
| cancelAnimationFrame(this.#scrollAnimationFrame); |
Contributor
Author
There was a problem hiding this comment.
Fixes Lit warning about chained updates
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19825 +/- ##
==========================================
- Coverage 93.25% 93.23% -0.03%
==========================================
Files 965 965
Lines 53184 53184
==========================================
- Hits 49598 49585 -13
- Misses 3586 3599 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5db9597 to
d084446
Compare
GirlBossRush
commented
Jan 29, 2026
Comment on lines
+159
to
+160
| "lit-element": "^4.2.2", | ||
| "lit-html": "^3.3.2", |
Contributor
Author
There was a problem hiding this comment.
Fix to hoist Lit into a single version
https://lit.dev/docs/tools/development/#multiple-lit-versions
d084446 to
fe7eb87
Compare
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d084446c58484e127048c736ce20e2d018b62bb8
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-d084446c58484e127048c736ce20e2d018b62bb8Afterwards, run the upgrade commands from the latest release notes. |
BeryJu
approved these changes
Jan 29, 2026
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 31, 2026
* main: (52 commits) website: QL Search keyboard interactions docs, examples. (#16259) website/integrations: immich: add signing algorithm (#19187) website/docs: endpoint devices: add version command (#19767) common: introduce common (#19852) web: bump @sentry/browser from 10.37.0 to 10.38.0 in /web in the sentry group across 1 directory (#19871) core: bump debugpy from 1.8.19 to 1.8.20 (#19872) ci: bump actions/cache from 5.0.2 to 5.0.3 (#19873) web: bump chromedriver from 144.0.1 to 145.0.0 in /web (#19874) web: Captcha Refinements, Part 2 (#19757) root: assign cherry-pick PRs to original author (#19858) web: Lit Development Mode, performance fixes. (#19825) web: Fix development theme overrides (#19826) website/docs: add tip for recovering from accidental main branch work (#19865) web: bump API Client version (#19857) rbac: clean up roles and permissions (#19588) web: bump API Client version (#19851) website/docs: add more info to entra id scim doc (#19849) sources/oauth: Fix an issue where wechat may crash duing login. (#18973) providers/scim: fix email validation mismatch (#19848) providers/scim: modify user- and group syncing behavior (#13947) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR enables Lit's development mode, adding additional console logs to track down non-idiomatic Lit.
Additionally, a small number of fixes for some common warnings are included such as:
requestUpdate.activeThemeproperty triggeringrequestUpdatefor elements without shadow roots.