Skip to content

rbac: clean up roles and permissions#19588

Merged
BeryJu merged 14 commits intomainfrom
rbac/clean-up-roles-and-permissions
Jan 29, 2026
Merged

rbac: clean up roles and permissions#19588
BeryJu merged 14 commits intomainfrom
rbac/clean-up-roles-and-permissions

Conversation

@gergosimonyi
Copy link
Collaborator

This was purposefully not included in 2025.12 to split the changes up.

The main content of this patch is in the migrations. Everything else follows more or less automatically.

@netlify
Copy link

netlify bot commented Jan 19, 2026

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 9424a05
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/697b96c760882300081131d2
😎 Deploy Preview https://deploy-preview-19588--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 19, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 9424a05
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/697b96c7063f230008af8585
😎 Deploy Preview https://deploy-preview-19588--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 19, 2026

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 9424a05
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/697b96c70a77b80008b7c0e3
😎 Deploy Preview https://deploy-preview-19588--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment on lines -11287 to -11288
"Heimdal",
"other"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change (and its analogue over at schema.yml) was automatically included when I ran make gen. I'll leave it in.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 88.67925% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.26%. Comparing base (387a3ef) to head (9424a05).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/outposts/models.py 0.00% 3 Missing ⚠️
authentik/providers/ldap/models.py 0.00% 3 Missing ⚠️
authentik/providers/radius/models.py 0.00% 3 Missing ⚠️
...ik/enterprise/providers/google_workspace/models.py 0.00% 1 Missing ⚠️
...tik/enterprise/providers/microsoft_entra/models.py 0.00% 1 Missing ⚠️
authentik/rbac/api/roles.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19588      +/-   ##
==========================================
+ Coverage   93.19%   93.26%   +0.06%     
==========================================
  Files         968      968              
  Lines       53307    53331      +24     
==========================================
+ Hits        49682    49738      +56     
+ Misses       3625     3593      -32     
Flag Coverage Δ
conformance 38.07% <16.03%> (-0.02%) ⬇️
e2e 44.08% <30.18%> (+1.05%) ⬆️
integration 22.92% <13.20%> (-0.01%) ⬇️
unit 91.41% <87.73%> (+<0.01%) ⬆️
unit-migrate 91.43% <87.73%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was purposefully not included in `2025.12` to split the changes up.

The main content of this patch is in the migrations. Everything else
follows more or less automatically.
@gergosimonyi gergosimonyi force-pushed the rbac/clean-up-roles-and-permissions branch from 9d3270b to 605edab Compare January 19, 2026 23:40
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-9424a051a2c2d5e770b9930516bafad1ee8e29d4
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-9424a051a2c2d5e770b9930516bafad1ee8e29d4

Afterwards, run the upgrade commands from the latest release notes.

@gergosimonyi gergosimonyi marked this pull request as ready for review January 20, 2026 00:17
@gergosimonyi gergosimonyi requested review from a team as code owners January 20, 2026 00:17
Comment on lines -364 to +368
ak_groups = models.ManyToManyField("Group", related_name="users")
groups = models.ManyToManyField("Group", related_name="users")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want some sort of proxy for the old field as its probably used in policies quite frequently, something that'll log an event when used.

Copy link
Collaborator Author

@gergosimonyi gergosimonyi Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this deserved its own EventAction, see 6fc2469 for my first pass on implementing this.

SYSTEM_EXCEPTION = "system_exception"

CONFIGURATION_ERROR = "configuration_error"
DEPRECATION_USED = "deprecation_used"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DEPRECATION_USED = "deprecation_used"
CONFIGURATION_WARNING = "configuration_warning"

Should make it a bit more re-usable for other things

Copy link
Member

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for docs

Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added one small comment to the release notes to tell people the old one is deprecated but will still work.

One other thing I suggest for this is splitting out the changes to integrations since those are not deployed from the version branch and as such will go live as soon as this is merged, so we should separate that and only merge it once this is out. (Or maybe even later since .ak_groups will still work)

gergosimonyi and others added 3 commits January 23, 2026 20:59
Co-authored-by: Jens L. <jens@goauthentik.io>
Signed-off-by: Simonyi Gergő <28359278+gergosimonyi@users.noreply.github.com>
These will be included in a separate PR once this is released.
@BeryJu BeryJu merged commit 1b96539 into main Jan 29, 2026
101 of 102 checks passed
@BeryJu BeryJu deleted the rbac/clean-up-roles-and-permissions branch January 29, 2026 18:12
kensternberg-authentik added a commit that referenced this pull request Jan 31, 2026
* main: (52 commits)
  website: QL Search keyboard interactions docs, examples. (#16259)
  website/integrations: immich: add signing algorithm (#19187)
  website/docs: endpoint devices: add version command (#19767)
  common: introduce common (#19852)
  web: bump @sentry/browser from 10.37.0 to 10.38.0 in /web in the sentry group across 1 directory (#19871)
  core: bump debugpy from 1.8.19 to 1.8.20 (#19872)
  ci: bump actions/cache from 5.0.2 to 5.0.3 (#19873)
  web: bump chromedriver from 144.0.1 to 145.0.0 in /web (#19874)
  web: Captcha Refinements, Part 2  (#19757)
  root: assign cherry-pick PRs to original author (#19858)
  web: Lit Development Mode, performance fixes. (#19825)
  web: Fix development theme overrides (#19826)
  website/docs: add tip for recovering from accidental main branch work (#19865)
  web: bump API Client version (#19857)
  rbac: clean up roles and permissions (#19588)
  web: bump API Client version (#19851)
  website/docs: add more info to entra id scim doc (#19849)
  sources/oauth: Fix an issue where wechat may crash duing login. (#18973)
  providers/scim: fix email validation mismatch (#19848)
  providers/scim: modify user- and group syncing behavior (#13947)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants