Skip to content

admin/files: cache expensive generated URLs#18784

Merged
rissson merged 1 commit intomainfrom
files-url-cache
Dec 12, 2025
Merged

admin/files: cache expensive generated URLs#18784
rissson merged 1 commit intomainfrom
files-url-cache

Conversation

@rissson
Copy link
Member

@rissson rissson commented Dec 12, 2025

Details

Closes #18420
See #18764


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson added this to the Release 2025.12 milestone Dec 12, 2025
@rissson rissson self-assigned this Dec 12, 2025
@rissson rissson requested a review from a team as a code owner December 12, 2025 13:03
@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit fc74197
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/693c12b7169fe8000898dcd4

@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit fc74197
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/693c12b7cd8f720008b1282b

@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit fc74197
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/693c12b7169fe8000898dcd8
😎 Deploy Preview https://deploy-preview-18784--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rissson rissson changed the title admin/files: cache expansive generated URLs admin/files: cache expensive generated URLs Dec 12, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in authentik Core Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.18%. Comparing base (cafe9e3) to head (fc74197).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/admin/files/backends/base.py 93.33% 1 Missing ⚠️
authentik/admin/files/backends/file.py 92.30% 1 Missing ⚠️
authentik/admin/files/backends/s3.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18784      +/-   ##
==========================================
+ Coverage   93.01%   93.18%   +0.17%     
==========================================
  Files         946      946              
  Lines       51862    51884      +22     
==========================================
+ Hits        48238    48348     +110     
+ Misses       3624     3536      -88     
Flag Coverage Δ
e2e 44.78% <22.72%> (+1.02%) ⬆️
integration 23.23% <22.72%> (-0.06%) ⬇️
unit 91.46% <93.18%> (-0.01%) ⬇️
unit-migrate 91.51% <93.18%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson enabled auto-merge (squash) December 12, 2025 13:22
@rissson rissson merged commit ae019eb into main Dec 12, 2025
136 of 138 checks passed
@rissson rissson deleted the files-url-cache branch December 12, 2025 13:41
@github-project-automation github-project-automation bot moved this from In Progress to Done in authentik Core Dec 12, 2025
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-fc74197430a32a51b56fdbfadf713fed18ef6688
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-fc74197430a32a51b56fdbfadf713fed18ef6688

Afterwards, run the upgrade commands from the latest release notes.

kensternberg-authentik added a commit that referenced this pull request Dec 12, 2025
* main:
  web/admin: fix typo in PolicyAccessView (#18789)
  translate: Updates for project authentik and language fr_FR (#18788)
  core: bump goauthentik/fips-debian from `dea09c4` to `07f41ce` (#18778)
  admin/files: cache expensive generated URLs (#18784)
  ci: bump actions/cache from 4.3.0 to 5.0.0 (#18779)
  ci: bump tj-actions/changed-files from 47.0.0 to 47.0.1 (#18780)
  core: bump goauthentik.io/api/v3 from 3.2025120.25 to 3.2025120.26 (#18770)
  core: bump selenium/standalone-chromium from 142.0 to 143.0 in /tests/e2e (#18772)
  web: bump types (merge branch) (#18735)
  ci: generate typescript api client for release too (#18761)
  website/integrations: wazuh: Change exchange key generation to 64 bytes (#18769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Option to skip pre-signing S3 URLs

2 participants