Skip to content

web: Fix background refreshing too frequently.#18764

Merged
GirlBossRush merged 1 commit intomainfrom
fix-background-loading
Dec 12, 2025
Merged

web: Fix background refreshing too frequently.#18764
GirlBossRush merged 1 commit intomainfrom
fix-background-loading

Conversation

@GirlBossRush
Copy link
Contributor

Details

This fixes a bug introduced in the #17535 where background images that differ by their query params trigger a repaint.

@GirlBossRush GirlBossRush added this to the Release 2025.12 milestone Dec 11, 2025
@GirlBossRush GirlBossRush requested a review from BeryJu December 11, 2025 21:45
@GirlBossRush GirlBossRush requested a review from a team as a code owner December 11, 2025 21:45
@GirlBossRush GirlBossRush added bug Something isn't working area:frontend Features or issues related to the browser, TypeScript, Node.js, etc labels Dec 11, 2025
@netlify
Copy link

netlify bot commented Dec 11, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 083a1e9
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/693c58a353af600008c8e308
😎 Deploy Preview https://deploy-preview-18764--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 11, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit 083a1e9
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/693c58a36fb6780008ac7708

@netlify
Copy link

netlify bot commented Dec 11, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 083a1e9
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/693c58a3a7be5100085cc625
😎 Deploy Preview https://deploy-preview-18764--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.22%. Comparing base (94ae8b7) to head (083a1e9).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18764   +/-   ##
=======================================
  Coverage   93.22%   93.22%           
=======================================
  Files         946      946           
  Lines       51903    51903           
=======================================
  Hits        48388    48388           
  Misses       3515     3515           
Flag Coverage Δ
e2e 44.75% <ø> (-0.02%) ⬇️
integration 23.28% <ø> (+<0.01%) ⬆️
unit 91.47% <ø> (+<0.01%) ⬆️
unit-migrate 91.51% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson
Copy link
Member

rissson commented Dec 12, 2025

We should re-evaluate if this is still necessary after #18784

@GirlBossRush GirlBossRush force-pushed the fix-background-loading branch from 12dbe35 to 083a1e9 Compare December 12, 2025 18:02
Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-083a1e9e3eff7d0e4418beab0c387f4ceb11d9b3
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-083a1e9e3eff7d0e4418beab0c387f4ceb11d9b3

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush merged commit 17489fa into main Dec 12, 2025
98 checks passed
@GirlBossRush GirlBossRush deleted the fix-background-loading branch December 12, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Features or issues related to the browser, TypeScript, Node.js, etc bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants