Skip to content

stages/prompt: fix choices with labels causing error on submit#18183

Merged
BeryJu merged 2 commits intomainfrom
stages/prompt/fix-choices
Nov 18, 2025
Merged

stages/prompt: fix choices with labels causing error on submit#18183
BeryJu merged 2 commits intomainfrom
stages/prompt/fix-choices

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 17, 2025

ref #16693

no idea how this wasn't caught with testing

@BeryJu BeryJu requested a review from a team as a code owner November 17, 2025 14:22
@BeryJu BeryJu requested a review from melizeche November 17, 2025 14:22
@BeryJu BeryJu added area:backend backport/version-2025.10 Add this label to PRs to backport changes to version-2025.10 labels Nov 17, 2025
@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for authentik-storybook failed. Why did it fail? →

Name Link
🔨 Latest commit 03f85e4
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/691c9c1dc321770008b2b26c

@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 03f85e4
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/691c9c1d8fc503000872891f
😎 Deploy Preview https://deploy-preview-18183--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 03f85e4
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/691c9c1d5290d2000845add1
😎 Deploy Preview https://deploy-preview-18183--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.85%. Comparing base (5451e04) to head (03f85e4).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/stages/prompt/models.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18183      +/-   ##
==========================================
- Coverage   92.97%   92.85%   -0.12%     
==========================================
  Files         869      869              
  Lines       48116    48123       +7     
==========================================
- Hits        44734    44684      -50     
- Misses       3382     3439      +57     
Flag Coverage Δ
e2e 45.12% <0.00%> (-0.11%) ⬇️
integration 23.12% <0.00%> (-0.06%) ⬇️
unit 91.06% <75.00%> (-0.01%) ⬇️
unit-migrate 91.11% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-03f85e453f1cdae66e98d6e188ab19371bf3bf89
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-03f85e453f1cdae66e98d6e188ab19371bf3bf89

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the stages/prompt/fix-choices branch from 101a443 to 03f85e4 Compare November 18, 2025 16:17
@BeryJu BeryJu merged commit 0913b10 into main Nov 18, 2025
93 of 98 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in authentik Core Nov 18, 2025
@BeryJu BeryJu deleted the stages/prompt/fix-choices branch November 18, 2025 17:04
authentik-automation bot pushed a commit that referenced this pull request Nov 18, 2025
* stages/prompt: fix choices with labels causing error on submit

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix tests

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@authentik-automation
Copy link
Contributor

🍒 Cherry-pick to version-2025.10 created: #18236

BeryJu added a commit that referenced this pull request Nov 18, 2025
…y-pick #18183 to version-2025.10) (#18236)

stages/prompt: fix choices with labels causing error on submit (#18183)

* stages/prompt: fix choices with labels causing error on submit



* fix tests



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Dec 11, 2025
* main: (55 commits)
  Makefile: Fix kerberos tests for brew users (#17223)
  website/docs: add 2025.8.5 and 2025.10.2 release notes (#18268)
  internal: Automated internal backport: 5000-sidebar.sec.patch to authentik-main (#18266)
  internal: Automated internal backport: 1498-oauth2-cc-user-active.sec.patch to authentik-main (#18265)
  internal: Automated internal backport: 1487-invitation-expiry.sec.patch to authentik-main (#18264)
  core, web: update translations (#18241)
  web: bump ts-pattern from 5.8.0 to 5.9.0 in /web (#18247)
  web: bump the react group across 2 directories with 1 update (#18244)
  web: bump knip from 5.66.2 to 5.70.0 in /web (#18245)
  core: bump library/nginx from `b5b9e01` to `553f64a` in /website (#18253)
  core: bump library/golang from `27e1c92` to `728cbef` (#18252)
  core: bump goauthentik/fips-debian from `65a9f1f` to `55c1514` (#18251)
  web: Bump Vitest, TypeScript config (#18238)
  web: bump js-yaml from 4.1.0 to 4.1.1 in /packages/esbuild-plugin-live-reload (#18237)
  web/i18n: Remove English Locale (#18164)
  web: bump js-yaml from 3.14.1 to 3.14.2 in /packages/docusaurus-config (#18239)
  web/i18n: Clean up locale scripts (#18163)
  stages/prompt: fix choices with labels causing error on submit (#18183)
  web: Patternfly 5 Prep: Part 2 (#18085)
  lifecycle/aws: bump aws-cdk from 2.1031.2 to 2.1032.0 in /lifecycle/aws (#18218)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend backport/version-2025.10 Add this label to PRs to backport changes to version-2025.10

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant