Makefile: Fix kerberos tests for brew users#17223
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17223 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 869 869
Lines 48040 48040
=======================================
Hits 44665 44665
Misses 3375 3375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Makefile
Outdated
| ifdef KRB5_EXISTS | ||
| PATH="$(shell brew --prefix krb5)/sbin:$(shell brew --prefix krb5)/bin:$$PATH" uv run coverage run manage.py test --keepdb authentik |
There was a problem hiding this comment.
I think you could probably just export the changed path and not need to duplicate command
There was a problem hiding this comment.
each physical line in a Makefile recipe is executed in a separate shell instance, so we can't export, but I did find a way to inject the path in that is much cleaner
|
@BeryJu I made an additional minor update with this — you can now run |
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-9856e3478a55578abfc4b86f2dcc69b687749fac
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-9856e3478a55578abfc4b86f2dcc69b687749facAfterwards, run the upgrade commands from the latest release notes. |
|
Using |
|
Some of this won't be necessary anymore after we fix krb5 for Heimdal, as the lib discovery has been improved to find the correct paths on Linux and macos |
|
Ah glad to hear. What are your thoughts @rissson ? Should we merge this for now and remove it after? or just remove the |
|
The kerberos PR should be ready soon, I'll edit this PR once that is merged |
|
Awesome, much appreciated |
|
actually no, it won't fix them, we can go ahead with this. |
d980f10 to
9856e34
Compare
|
Do you have time for a review on this @rissson ? |
Makefile: Fix kerberos tests for brew users Co-authored-by: connor peshek <connorpeshek@connors-MacBook-Pro.local>
* main: (55 commits) Makefile: Fix kerberos tests for brew users (#17223) website/docs: add 2025.8.5 and 2025.10.2 release notes (#18268) internal: Automated internal backport: 5000-sidebar.sec.patch to authentik-main (#18266) internal: Automated internal backport: 1498-oauth2-cc-user-active.sec.patch to authentik-main (#18265) internal: Automated internal backport: 1487-invitation-expiry.sec.patch to authentik-main (#18264) core, web: update translations (#18241) web: bump ts-pattern from 5.8.0 to 5.9.0 in /web (#18247) web: bump the react group across 2 directories with 1 update (#18244) web: bump knip from 5.66.2 to 5.70.0 in /web (#18245) core: bump library/nginx from `b5b9e01` to `553f64a` in /website (#18253) core: bump library/golang from `27e1c92` to `728cbef` (#18252) core: bump goauthentik/fips-debian from `65a9f1f` to `55c1514` (#18251) web: Bump Vitest, TypeScript config (#18238) web: bump js-yaml from 4.1.0 to 4.1.1 in /packages/esbuild-plugin-live-reload (#18237) web/i18n: Remove English Locale (#18164) web: bump js-yaml from 3.14.1 to 3.14.2 in /packages/docusaurus-config (#18239) web/i18n: Clean up locale scripts (#18163) stages/prompt: fix choices with labels causing error on submit (#18183) web: Patternfly 5 Prep: Part 2 (#18085) lifecycle/aws: bump aws-cdk from 2.1031.2 to 2.1032.0 in /lifecycle/aws (#18218) ...
Details
We tell people to install krb5 with brew on dev env setup. The output from running
brew install krb5tells people they have to update their path to add krb5 manually. This is very easy to miss, and without it in your path, the tests inauthentik/sources/kerberoswill hang infinitely.This PR automatically updates your path to add the brew install of krb5 when the test suite is run via
make testormake allChecklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)