Skip to content

brands: sort matched brand by match length#17920

Merged
rissson merged 11 commits intomainfrom
brand-sort-match-length
Nov 4, 2025
Merged

brands: sort matched brand by match length#17920
rissson merged 11 commits intomainfrom
brand-sort-match-length

Conversation

@rissson
Copy link
Member

@rissson rissson commented Nov 3, 2025

Second take on #15413, this time with more tests

Needs #16185

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson added this to the Release 2025.10.3 milestone Nov 3, 2025
@rissson rissson self-assigned this Nov 3, 2025
@rissson rissson requested a review from a team as a code owner November 3, 2025 16:19
@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit 9e21392
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6909f5bce4a3fa0008cb7d44

@rissson rissson added area:backend backport/version-2025.10 Add this label to PRs to backport changes to version-2025.10 labels Nov 3, 2025
@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 9e21392
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6909f5bc42162100080c4984

@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 9e21392
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/6909f5bc978cb100081d6d10

@rissson rissson changed the title brands: reproduce matching error brands: sort matched brand by match length Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.93%. Comparing base (e2e7021) to head (9e21392).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17920      +/-   ##
==========================================
+ Coverage   92.63%   92.93%   +0.29%     
==========================================
  Files         869      869              
  Lines       47987    47986       -1     
==========================================
+ Hits        44455    44598     +143     
+ Misses       3532     3388     -144     
Flag Coverage Δ
e2e 45.16% <35.71%> (+3.30%) ⬆️
integration 23.18% <14.28%> (+<0.01%) ⬆️
unit 91.08% <100.00%> (+21.15%) ⬆️
unit-migrate 91.13% <100.00%> (+7.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson moved this from Todo to In Progress in authentik Core Nov 3, 2025
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson moved this from In Progress to Needs review in authentik Core Nov 4, 2025
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-9e213927dd31a55982df482c9a83aa010d76bc4a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-9e213927dd31a55982df482c9a83aa010d76bc4a

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postgres go brr

@github-project-automation github-project-automation bot moved this from Needs review to In Progress in authentik Core Nov 4, 2025
@rissson rissson merged commit 945c2d8 into main Nov 4, 2025
98 checks passed
@rissson rissson deleted the brand-sort-match-length branch November 4, 2025 13:22
@github-project-automation github-project-automation bot moved this from In Progress to Done in authentik Core Nov 4, 2025
@authentik-automation
Copy link
Contributor

🍒 Cherry-pick to version-2025.10 created: #17935

rissson added a commit that referenced this pull request Nov 4, 2025
…rsion-2025.10) (#17935)

Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
kensternberg-authentik added a commit that referenced this pull request Nov 10, 2025
* main:
  webiste/docs: remove broken info box and fix sentence (#17963)
  web/admin: fixes capitalization in application wizard title (#17959)
  website/docs: added Note about email_verified scope mapping is set to false by default (#17942)
  crypto: update certificate api and component (#17921)
  core: bump openapitools/openapi-diff from 2.1.4 to 2.1.5 in /scripts/api (#17929)
  ci: bump getsentry/action-release from 3.3.0 to 3.4.0 (#17931)
  ci: bump helm/kind-action from 1.12.0 to 1.13.0 (#17930)
  tasks/schedules: fix rel obj not being associated or updated (#17934)
  core, web: update translations (#17807)
  brands: sort matched brand by match length (#17920)
  web: bump the storybook group across 1 directory with 5 updates (#17787)
  brands: add more matching tests (#16185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend backport/version-2025.10 Add this label to PRs to backport changes to version-2025.10

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants