Skip to content

brands: add more matching tests#16185

Merged
BeryJu merged 10 commits intomainfrom
brand-matching-reproduce
Nov 3, 2025
Merged

brands: add more matching tests#16185
BeryJu merged 10 commits intomainfrom
brand-matching-reproduce

Conversation

@rissson
Copy link
Member

@rissson rissson commented Aug 14, 2025

No description provided.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson self-assigned this Aug 14, 2025
@rissson rissson requested a review from a team as a code owner August 14, 2025 11:18
@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 194ff83
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6908dfcdaaf7550008899a25
😎 Deploy Preview https://deploy-preview-16185--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 194ff83
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6908dfcd8c2b2b0008f1dd3f
😎 Deploy Preview https://deploy-preview-16185--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 194ff83
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/6908dfcd9e49070008089bfb

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (30f9d19) to head (194ff83).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16185   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         869      869           
  Lines       47962    47987   +25     
=======================================
+ Hits        44596    44623   +27     
+ Misses       3366     3364    -2     
Flag Coverage Δ
e2e 45.23% <0.00%> (-0.02%) ⬇️
integration 23.18% <0.00%> (-0.02%) ⬇️
unit 91.08% <100.00%> (+0.01%) ⬆️
unit-migrate 91.13% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson changed the title brands: reproduce matching error brands: add more matching tests Sep 22, 2025
Copy link
Member

@melizeche melizeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson requested a review from melizeche September 22, 2025 14:20
@rissson rissson enabled auto-merge (squash) September 22, 2025 14:20
@rissson rissson moved this to Todo in authentik Core Oct 24, 2025
@rissson rissson moved this from Todo to In Progress in authentik Core Nov 3, 2025
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson moved this from In Progress to Needs review in authentik Core Nov 3, 2025
@rissson rissson added the backport/version-2025.10 Add this label to PRs to backport changes to version-2025.10 label Nov 3, 2025
Co-authored-by: Jens L. <jens@goauthentik.io>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson added this to the Release 2025.10.3 milestone Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-194ff83057a61cffe7e79e136432c00024c01f63
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-194ff83057a61cffe7e79e136432c00024c01f63

Afterwards, run the upgrade commands from the latest release notes.

@rissson rissson disabled auto-merge November 3, 2025 18:03
@rissson rissson requested a review from BeryJu November 3, 2025 18:03
@BeryJu BeryJu merged commit b02a0a7 into main Nov 3, 2025
136 of 138 checks passed
@BeryJu BeryJu deleted the brand-matching-reproduce branch November 3, 2025 19:31
@github-project-automation github-project-automation bot moved this from Needs review to Done in authentik Core Nov 3, 2025
authentik-automation bot pushed a commit that referenced this pull request Nov 3, 2025
* brands: reproduce matching error

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

* try some things

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

* fix tests

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

* fix tests

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

* Update authentik/brands/tests.py

Co-authored-by: Jens L. <jens@goauthentik.io>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

* fix tests again?

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

* wip

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

---------

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Co-authored-by: Jens L. <jens@goauthentik.io>
@authentik-automation
Copy link
Contributor

🍒 Cherry-pick to version-2025.10 created: #17924

rissson added a commit that referenced this pull request Nov 3, 2025
…0) (#17924)

brands: add more matching tests (#16185)

* brands: reproduce matching error



* try some things



* fix tests



* fix tests



* Update authentik/brands/tests.py




* fix tests again?



* wip



---------

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Nov 10, 2025
* main:
  webiste/docs: remove broken info box and fix sentence (#17963)
  web/admin: fixes capitalization in application wizard title (#17959)
  website/docs: added Note about email_verified scope mapping is set to false by default (#17942)
  crypto: update certificate api and component (#17921)
  core: bump openapitools/openapi-diff from 2.1.4 to 2.1.5 in /scripts/api (#17929)
  ci: bump getsentry/action-release from 3.3.0 to 3.4.0 (#17931)
  ci: bump helm/kind-action from 1.12.0 to 1.13.0 (#17930)
  tasks/schedules: fix rel obj not being associated or updated (#17934)
  core, web: update translations (#17807)
  brands: sort matched brand by match length (#17920)
  web: bump the storybook group across 1 directory with 5 updates (#17787)
  brands: add more matching tests (#16185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend backport/version-2025.10 Add this label to PRs to backport changes to version-2025.10

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants