Skip to content

web/a11y: Associating labels with inputs#16119

Merged
GirlBossRush merged 1 commit intomainfrom
a11y-functional-label-components-v2
Aug 21, 2025
Merged

web/a11y: Associating labels with inputs#16119
GirlBossRush merged 1 commit intomainfrom
a11y-functional-label-components-v2

Conversation

@GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Aug 12, 2025

Details

Split off from #15894

This PR resolves a collection of accessibility issues in labels within flow interfaces. The primary change here is a migration away from <ak-form-control /> to two functional components , AKLabel and AKFieldError.

Together, they bring the <label /> and <input /> element into the same DOM tree, allowing them to match htmlFor and id attributes as a screen-reader friendly pairing.

See also

@GirlBossRush GirlBossRush requested a review from a team as a code owner August 12, 2025 00:36
@netlify
Copy link

netlify bot commented Aug 12, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 5b8adfc
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68a75f9785676d0008d652d8

@netlify
Copy link

netlify bot commented Aug 12, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit 5b8adfc
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68a75f9795ccb70008fc0e6d

@GirlBossRush GirlBossRush force-pushed the a11y-functional-label-components branch from 37a52d6 to 144d377 Compare August 12, 2025 01:09
@GirlBossRush GirlBossRush force-pushed the a11y-functional-label-components-v2 branch from 5912b5d to 3d7cff0 Compare August 12, 2025 01:10
@GirlBossRush GirlBossRush added the a11y Features or issues related to accessibility label Aug 12, 2025
@BeryJu BeryJu force-pushed the a11y-functional-label-components-v2 branch from 1d9191b to 3d7cff0 Compare August 12, 2025 12:42
@GirlBossRush GirlBossRush force-pushed the a11y-functional-label-components branch from 9a37950 to d01b0b9 Compare August 12, 2025 13:48
Base automatically changed from a11y-functional-label-components to main August 12, 2025 14:34
@GirlBossRush GirlBossRush force-pushed the a11y-functional-label-components-v2 branch from 3d7cff0 to 28353cc Compare August 20, 2025 16:59
@netlify
Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 5b8adfc
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68a75f97bda02800088c8023

@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.83%. Comparing base (e7b43b7) to head (5b8adfc).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16119      +/-   ##
==========================================
+ Coverage   92.41%   92.83%   +0.42%     
==========================================
  Files         837      837              
  Lines       45253    45253              
==========================================
+ Hits        41821    42012     +191     
+ Misses       3432     3241     -191     
Flag Coverage Δ
e2e 46.71% <ø> (+1.92%) ⬆️
integration 23.55% <ø> (+<0.01%) ⬆️
unit 90.93% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-5b8adfce3f54f70a5c3c73a002b6021c69a2a047
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-5b8adfce3f54f70a5c3c73a002b6021c69a2a047

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A consistent set of fixes.

@GirlBossRush GirlBossRush force-pushed the a11y-functional-label-components-v2 branch 2 times, most recently from c7b61b5 to d615dbb Compare August 21, 2025 17:10
@GirlBossRush GirlBossRush enabled auto-merge (squash) August 21, 2025 17:21
web: Add correct ID to stage inputs.
@GirlBossRush GirlBossRush force-pushed the a11y-functional-label-components-v2 branch from d615dbb to 5b8adfc Compare August 21, 2025 18:04
@GirlBossRush GirlBossRush merged commit 7861f5a into main Aug 21, 2025
107 checks passed
@GirlBossRush GirlBossRush deleted the a11y-functional-label-components-v2 branch August 21, 2025 18:28
kensternberg-authentik added a commit that referenced this pull request Aug 26, 2025
* main:
  providers/oauth2: avoid deadlock during session migration (#16361)
  lifecycle/aws: bump aws-cdk from 2.1025.0 to 2.1026.0 in /lifecycle/aws (#16352)
  core: bump github.com/stretchr/testify from 1.10.0 to 1.11.0 (#16357)
  core: bump axllent/mailpit from v1.27.5 to v1.27.6 in /tests/e2e (#16358)
  website/docs: fix missing trailing slash in vaultwarden documentation (#16348)
  root: fix security.md (#16345)
  root: update security.md with github reporting link (#16332)
  website/docs: 2025.8.1 release notes (#16343)
  packages/django-dramatiq-postgres: broker: fix various timing issues (#16340)
  website/docs: adds details to certificates doc (#16335)
  outposts: allow ingress path type configuration (#16339)
  core, web: update translations (#16321)
  outposts: fix service connection update task arguments (#16312)
  core: use email backend for test_email management command (#16311)
  core: bump astral-sh/uv from 0.8.12 to 0.8.13 (#16325)
  website: Move docs netlify.toml (#16320)
  website/docs: add link in 2025.8 rel notes to back-channel logout docs (#16306)
  packages/django-dramatiq-postgres: middleware: fix listening on hosts where ipv6 is not supported (#16308)
  website: Fix version origin detection, build-time URLs  (#15774)
  web/a11y: Associating labels with inputs (#16119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Features or issues related to accessibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants