Skip to content

web/a11y: Wizards & Forms#15701

Closed
GirlBossRush wants to merge 1 commit intomainfrom
a11y-wizards
Closed

web/a11y: Wizards & Forms#15701
GirlBossRush wants to merge 1 commit intomainfrom
a11y-wizards

Conversation

@GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Jul 21, 2025

Depends on

Details

This PR continues the a11y-ification of the UI, adding additional labels for wizards, tables, inputs, navigations -- Pretty much everything the test suite needs to traverse the DOM.

Screenshot 2025-07-21 at 22 24 44 Screenshot 2025-07-21 at 22 33 55

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

See also

@GirlBossRush GirlBossRush requested a review from a team as a code owner July 21, 2025 20:36
@netlify
Copy link

netlify bot commented Jul 21, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit feb0a93
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68ae0bb330a9420008ec7e01

@netlify
Copy link

netlify bot commented Jul 21, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit feb0a93
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68ae0bb3a38a1300084cffec

@netlify
Copy link

netlify bot commented Jul 21, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit feb0a93
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68ae0bb33ea027000832e28e
😎 Deploy Preview https://deploy-preview-15701--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.78%. Comparing base (36bf0a7) to head (feb0a93).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15701      +/-   ##
==========================================
+ Coverage   92.59%   92.78%   +0.18%     
==========================================
  Files         838      838              
  Lines       45290    45290              
==========================================
+ Hits        41938    42024      +86     
+ Misses       3352     3266      -86     
Flag Coverage Δ
e2e 46.57% <ø> (+0.60%) ⬆️
integration 23.53% <ø> (+<0.01%) ⬆️
unit 90.93% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-feb0a93ef0f9a8bba7259aafc64290dfdc61023c
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-feb0a93ef0f9a8bba7259aafc64290dfdc61023c

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush added enhancement/confirmed Enhancements that will be implemented in the future a11y Features or issues related to accessibility labels Jul 21, 2025
@GirlBossRush GirlBossRush self-assigned this Jul 21, 2025
@GirlBossRush GirlBossRush force-pushed the a11y-wizards branch 3 times, most recently from 61d6db1 to f98eeb7 Compare July 30, 2025 01:42
@GirlBossRush GirlBossRush changed the title web: a11y -- wizards, form elements, inputs, etc web/a11y: wizards, form elements, inputs, etc Jul 30, 2025
@GirlBossRush GirlBossRush changed the title web/a11y: wizards, form elements, inputs, etc web/a11y: Wizards & Forms Jul 30, 2025
@GirlBossRush GirlBossRush mentioned this pull request Jul 30, 2025
6 tasks
Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see what you're trying to achieve here, and I approve of the work. I just want it to move in more... elemental... direction. Eventually. :-)


@property({ type: Boolean, attribute: true, reflect: true })
enabled = false;
public enabled?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A familiar complaint. If it's false and reflect: true, it will not appear in the tag.

*/
@property({ type: Boolean })
isValid = false;
public isValid?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tsk!

@GirlBossRush
Copy link
Contributor Author

Resolved in #16014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Features or issues related to accessibility enhancement/confirmed Enhancements that will be implemented in the future

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants