Skip to content

brands: fix custom_css being escaped#14994

Merged
BeryJu merged 2 commits intomainfrom
brands/fix-custom-css-escape
Jun 10, 2025
Merged

brands: fix custom_css being escaped#14994
BeryJu merged 2 commits intomainfrom
brands/fix-custom-css-escape

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Jun 10, 2025

Details

closes #14958


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner June 10, 2025 14:16
@netlify
Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit d10e3f0
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68484713cd7bab00080da861

@BeryJu
Copy link
Member Author

BeryJu commented Jun 10, 2025

/cherry-pick version-2025.6

@netlify
Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit d10e3f0
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68484713cd106100082ed82c
😎 Deploy Preview https://deploy-preview-14994--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (e22e79f) to head (d10e3f0).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14994   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files         815      815           
  Lines       42095    42105   +10     
=======================================
+ Hits        39048    39058   +10     
  Misses       3047     3047           
Flag Coverage Δ
e2e 47.66% <30.00%> (-0.01%) ⬇️
integration 24.33% <20.00%> (-0.01%) ⬇️
unit 90.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d10e3f09533e0c7772d420c80f1cf7709136e1e3
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-d10e3f09533e0c7772d420c80f1cf7709136e1e3

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 86dd1a9 into main Jun 10, 2025
101 checks passed
@BeryJu BeryJu deleted the brands/fix-custom-css-escape branch June 10, 2025 15:19
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 10, 2025
* brands: fix custom_css being escaped

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* escape adequately

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Jun 10, 2025
brands: fix custom_css being escaped (#14994)

* brands: fix custom_css being escaped



* escape adequately



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Jun 10, 2025
* main: (21 commits)
  web/admin: fix language in certificate import  (#14953)
  website/integrations: add new categories and update sidebar info (#14995)
  brands: fix custom_css being escaped (#14994)
  web/admin: show selected policy engine mode on bindings pages, allow setting it on sources (#12963)
  website/integrations: add bitwarden (#14922)
  core: bump goauthentik.io/api/v3 from 3.2025061.1 to 3.2025061.2 (#14986)
  website: bump @types/node from 22.15.30 to 24.0.0 in /website (#14988)
  website: bump the eslint group in /website with 3 updates (#14987)
  web: bump the eslint group across 2 directories with 3 updates (#14991)
  website/integrations: fix typos, update language and styling (#14978)
  website/integrations: add 1password (#14815)
  website/integrations: add nextcloud ldap config and update doc to new styling (#14866)
  outposts: Refactor session end signal and add LDAP support (#14539)
  core: bump cryptography from 45.0.3 to 45.0.4 (#14989)
  core: bump goauthentik/fips-python from 3.13.3-slim-bookworm-fips to 3.13.4-slim-bookworm-fips (#14990)
  web: bump API Client version (#14985)
  core, web: update translations (#14984)
  events: rework metrics endpoint (#14934)
  website/integrations: replaces all kbd and em tags (#14980)
  internal/outpost: fix incorrect usage of golang SHA API (#14981)
  ...
kensternberg-authentik added a commit that referenced this pull request Jun 12, 2025
* main: (30 commits)
  web/elements: Add light mode custom css handling (#14944)
  website/docs: add host header dynamic property mapping (#15006)
  core, web: update translations (#14999)
  website/docs: fixes misplaced sentence (#14998)
  website/docs: note usage of `is_restored` by source stage (#13422)
  website: bump the build group in /website with 6 updates (#15001)
  web: bump @sentry/browser from 9.27.0 to 9.28.0 in /web in the sentry group across 1 directory (#15002)
  core: bump msgraph-sdk from 1.32.0 to 1.33.0 (#15003)
  core: bump google-api-python-client from 2.171.0 to 2.172.0 (#15004)
  web/admin: fix language in certificate import  (#14953)
  website/integrations: add new categories and update sidebar info (#14995)
  brands: fix custom_css being escaped (#14994)
  web/admin: show selected policy engine mode on bindings pages, allow setting it on sources (#12963)
  website/integrations: add bitwarden (#14922)
  core: bump goauthentik.io/api/v3 from 3.2025061.1 to 3.2025061.2 (#14986)
  website: bump @types/node from 22.15.30 to 24.0.0 in /website (#14988)
  website: bump the eslint group in /website with 3 updates (#14987)
  web: bump the eslint group across 2 directories with 3 updates (#14991)
  website/integrations: fix typos, update language and styling (#14978)
  website/integrations: add 1password (#14815)
  ...
cavefire pushed a commit to cavefire/authentik that referenced this pull request Jun 24, 2025
* brands: fix custom_css being escaped

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* escape adequately

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Branding: custom CSS: font families using quoted strings don't work

1 participant