web/elements: Add light mode custom css handling#14944
Merged
GirlBossRush merged 2 commits intogoauthentik:mainfrom Jun 11, 2025
Merged
web/elements: Add light mode custom css handling#14944GirlBossRush merged 2 commits intogoauthentik:mainfrom
GirlBossRush merged 2 commits intogoauthentik:mainfrom
Conversation
Signed-off-by: CodeMax IT Solutions Pvt. Ltd. <137166088+cdmx1@users.noreply.github.com>
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14944 +/- ##
==========================================
- Coverage 92.77% 92.77% -0.01%
==========================================
Files 818 818
Lines 42196 42196
==========================================
- Hits 39149 39148 -1
- Misses 3047 3048 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: CodeMax IT Solutions Pvt. Ltd. <137166088+cdmx1@users.noreply.github.com>
GirlBossRush
approved these changes
Jun 11, 2025
kensternberg-authentik
added a commit
that referenced
this pull request
Jun 11, 2025
* main: web/elements: Add light mode custom css handling (#14944) website/docs: add host header dynamic property mapping (#15006) core, web: update translations (#14999) website/docs: fixes misplaced sentence (#14998) website/docs: note usage of `is_restored` by source stage (#13422) website: bump the build group in /website with 6 updates (#15001) web: bump @sentry/browser from 9.27.0 to 9.28.0 in /web in the sentry group across 1 directory (#15002) core: bump msgraph-sdk from 1.32.0 to 1.33.0 (#15003) core: bump google-api-python-client from 2.171.0 to 2.172.0 (#15004)
kensternberg-authentik
added a commit
that referenced
this pull request
Jun 12, 2025
* main: (30 commits) web/elements: Add light mode custom css handling (#14944) website/docs: add host header dynamic property mapping (#15006) core, web: update translations (#14999) website/docs: fixes misplaced sentence (#14998) website/docs: note usage of `is_restored` by source stage (#13422) website: bump the build group in /website with 6 updates (#15001) web: bump @sentry/browser from 9.27.0 to 9.28.0 in /web in the sentry group across 1 directory (#15002) core: bump msgraph-sdk from 1.32.0 to 1.33.0 (#15003) core: bump google-api-python-client from 2.171.0 to 2.172.0 (#15004) web/admin: fix language in certificate import (#14953) website/integrations: add new categories and update sidebar info (#14995) brands: fix custom_css being escaped (#14994) web/admin: show selected policy engine mode on bindings pages, allow setting it on sources (#12963) website/integrations: add bitwarden (#14922) core: bump goauthentik.io/api/v3 from 3.2025061.1 to 3.2025061.2 (#14986) website: bump @types/node from 22.15.30 to 24.0.0 in /website (#14988) website: bump the eslint group in /website with 3 updates (#14987) web: bump the eslint group across 2 directories with 3 updates (#14991) website/integrations: fix typos, update language and styling (#14978) website/integrations: add 1password (#14815) ...
Member
|
/cherry-pick version-2025.6 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
* fix(ui): Add light mode custom css handling Signed-off-by: CodeMax IT Solutions Pvt. Ltd. <137166088+cdmx1@users.noreply.github.com> * Update Base.ts Signed-off-by: CodeMax IT Solutions Pvt. Ltd. <137166088+cdmx1@users.noreply.github.com> --------- Signed-off-by: CodeMax IT Solutions Pvt. Ltd. <137166088+cdmx1@users.noreply.github.com>
BeryJu
pushed a commit
that referenced
this pull request
Jun 17, 2025
…#15096) web/elements: Add light mode custom css handling (#14944) * fix(ui): Add light mode custom css handling * Update Base.ts --------- Signed-off-by: CodeMax IT Solutions Pvt. Ltd. <137166088+cdmx1@users.noreply.github.com> Co-authored-by: CodeMax IT Solutions Pvt. Ltd. <137166088+cdmx1@users.noreply.github.com>
cavefire
pushed a commit
to cavefire/authentik
that referenced
this pull request
Jun 24, 2025
* fix(ui): Add light mode custom css handling Signed-off-by: CodeMax IT Solutions Pvt. Ltd. <137166088+cdmx1@users.noreply.github.com> * Update Base.ts Signed-off-by: CodeMax IT Solutions Pvt. Ltd. <137166088+cdmx1@users.noreply.github.com> --------- Signed-off-by: CodeMax IT Solutions Pvt. Ltd. <137166088+cdmx1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes an issue where custom CSS was not being applied in light mode theme. The root cause was identified as a missing light mode case in the
styleRootsetter within theAKElementclass.Changes:
styleRootsetter to properly handle theme applicationapplyUIThemecall withUiThemeEnum.Lightand custom CSS stylesheetactiveThemeis properly set for light modeThis change ensures consistent behavior of custom CSS application across all theme modes (dark, light, and auto), improving the user experience particularly for those using light mode themes.
No new requirements or breaking changes are introduced.