Skip to content

web: saml provider view: fix state refresh issues#14474

Merged
GirlBossRush merged 8 commits intogoauthentik:mainfrom
dominic-r:sdko/can-download-cert-wo-refresh
Aug 21, 2025
Merged

web: saml provider view: fix state refresh issues#14474
GirlBossRush merged 8 commits intogoauthentik:mainfrom
dominic-r:sdko/can-download-cert-wo-refresh

Conversation

@dominic-r
Copy link
Member

@dominic-r dominic-r commented May 12, 2025

Fixes the following issues:

  1. Fixed incorrect certificate download when changing a signing certificate - previously, clicking "Download Signing Certificate" after updating a certificate would still download the old certificate until the page was refreshed.
  2. Fixed missing UI updates when adding a signing certificate - previously, when a signing certificate was added to a provider, the download button wouldn't appear until the page was refreshed.
  3. Fixed persistent download button when removing a certificate - previously, when a signing certificate was removed from a provider, the download button would still be visible until the page was refreshed.

Closes #14310

Test cases:

Issue 1:

  1. Create 2 certs under System > Certificates: cert1 and cert2
  2. Edit the provider and set signing certificate to cert1 and download it
  3. Now, edit and set it to cert2 and download it. cert2 should get downloaded this time

Issue 2:

  1. Remove signing certificate and refresh. Now there's no cert and no button.
  2. Add cert1 and click save and check if the download cert button appears.

Issue 3:

  1. Edit the provider and remove cert1.
  2. Check if the download cert button is gone.

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Fixes the following issues:
1. Fixed incorrect certificate download when changing a signing certificate - previously, clicking "Download Signing Certificate" after updating a certificate would still download the old certificate until the page was refreshed.
2. Fixed missing UI updates when adding a signing certificate - previously, when a signing certificate was added to a provider, the download button wouldn't appear until the page was refreshed.
3. Fixed persistent download button when removing a certificate - previously, when a signing certificate was removed from a provider, the download button would still be visible until the page was refreshed.
@dominic-r dominic-r requested a review from a team as a code owner May 12, 2025 01:03
@netlify
Copy link

netlify bot commented May 12, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit df73a25
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68370e76b805c80008f7124c
😎 Deploy Preview https://deploy-preview-14474--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented May 12, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit df73a25
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68370e76ee319f00087553e8
😎 Deploy Preview https://deploy-preview-14474--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.82%. Comparing base (1eefd83) to head (df73a25).
⚠️ Report is 1047 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14474   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         817      817           
  Lines       42162    42162           
=======================================
  Hits        39135    39135           
  Misses       3027     3027           
Flag Coverage Δ
e2e 47.69% <ø> (+<0.01%) ⬆️
integration 24.40% <ø> (ø)
unit 90.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GirlBossRush GirlBossRush merged commit 11c9015 into goauthentik:main Aug 21, 2025
98 checks passed
@dominic-r dominic-r deleted the sdko/can-download-cert-wo-refresh branch August 21, 2025 01:39
kensternberg-authentik added a commit that referenced this pull request Aug 26, 2025
* main: (210 commits)
  web: Username truncation, field alignment. (#16283)
  website/docs: adds a webhook header mapping example (#16301)
  web: Fix issue where form group uses unknown slot. (#16276)
  lifecycle: set PROMETHEUS_MULTIPROC_DIR as early as possible (#16298)
  providers/oauth2: fix logout token missing sid, fix wrong sub mode used (#16295)
  web: bump core-js from 3.45.0 to 3.45.1 in /web (#16290)
  root: Remove CODEOWNERS entries from docs/ directory (#16287)
  *: Fix dead doc link (#16288)
  web: saml provider view: fix state refresh issues (#14474)
  web: fix "Explore integrations" link in Quick actions (#16274)
  website/integrations: fix dead links to external docs (#16273)
  tasks: add rel_obj to system task exception event (#16270)
  website/docs: update 2025.8 release notes (#16269)
  web: bump @patternfly/elements from 4.1.0 to 4.2.0 in /web (#16265)
  web: bump mermaid from 11.9.0 to 11.10.0 in /web (#16263)
  web: bump @types/guacamole-common-js from 1.5.3 to 1.5.4 in /web (#16262)
  security: Bump supported versions (#16261)
  core: bump channels from 4.3.0 to v4.3.1 (#16260)
  translate: Updates for file web/xliff/en.xlf in cs_CZ (#16264)
  website: bump the eslint group in /website with 3 updates (#16248)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New signing certificate cannot be downloaded unless refresh

2 participants