website/integrations: adds missing trailing slash in homarr doc#14249
Merged
website/integrations: adds missing trailing slash in homarr doc#14249
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dominic-r
approved these changes
Apr 25, 2025
Member
dominic-r
left a comment
There was a problem hiding this comment.
After resolution of review suggestion, LGTM thanks Dewi
| AUTH_OIDC_CLIENT_ID=<Client ID from authentik> | ||
| AUTH_OIDC_CLIENT_SECRET=<Client secret from authentik> | ||
| AUTH_OIDC_ISSUER=https://authentik.company/application/o/<slug from authentik> | ||
| AUTH_OIDC_ISSUER=https://authentik.company/application/o/<slug from authentik>/ #Trailing slash is required |
Member
There was a problem hiding this comment.
Suggested change
| AUTH_OIDC_ISSUER=https://authentik.company/application/o/<slug from authentik>/ #Trailing slash is required | |
| AUTH_OIDC_ISSUER=https://authentik.company/application/o/<slug from authentik>/ |
A bit like the apache guacamole doc, we ended up removing the notice. Let's do the same here
Member
There was a problem hiding this comment.
p.s. this gives me the idea for another task: standardize the slug angle bracket variables
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #14249 +/- ##
==========================================
+ Coverage 92.70% 92.76% +0.05%
==========================================
Files 809 809
Lines 41533 41533
==========================================
+ Hits 38504 38527 +23
+ Misses 3029 3006 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-755cb97a10f290d4921a1cc8463a01cc980e25f7
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-755cb97a10f290d4921a1cc8463a01cc980e25f7Afterwards, run the upgrade commands from the latest release notes. |
tanberry
approved these changes
Apr 25, 2025
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 25, 2025
* main: (33 commits) website/integrations: adds missing trailing slash in homarr doc (#14249) lifecycle: fix test-all in docker (#14244) core, web: update translations (#14243) web/admin: prevent default logo flashing in admin interface (#13960) website/docs: Update release notes for 2025.4 (#14158) core, web: update translations (#14241) Updates for file web/xliff/en.xlf in zh_TW [Manual Sync] (#14225) translate: Updates for file web/xliff/en.xlf in nl [Manual Sync] (#14217) translate: Updates for file web/xliff/en.xlf in fi [Manual Sync] (#14219) translate: Updates for file web/xliff/en.xlf in de [Manual Sync] (#14220) translate: Updates for file web/xliff/en.xlf in fr [Manual Sync] (#14221) translate: Updates for file web/xliff/en.xlf in pl [Manual Sync] (#14222) translate: Updates for file locale/en/LC_MESSAGES/django.po in es [Manual Sync] (#14223) translate: Updates for file web/xliff/en.xlf in zh-Hans [Manual Sync] (#14224) translate: Updates for file locale/en/LC_MESSAGES/django.po in de [Manual Sync] (#14226) translate: Updates for file locale/en/LC_MESSAGES/django.po in fi [Manual Sync] (#14227) translate: Updates for file web/xliff/en.xlf in tr [Manual Sync] (#14228) translate: Updates for file locale/en/LC_MESSAGES/django.po in pl [Manual Sync] (#14229) translate: Updates for file locale/en/LC_MESSAGES/django.po in ko [Manual Sync] (#14230) translate: Updates for file locale/en/LC_MESSAGES/django.po in it [Manual Sync] (#14231) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Closes #14248
Adds a required trailing slash to the
AUTH_OIDC_ISSUERURLChecklist
If applicable
make website)