web/admin: prevent default logo flashing in admin interface#13960
Merged
BeryJu merged 3 commits intogoauthentik:mainfrom Apr 25, 2025
Merged
web/admin: prevent default logo flashing in admin interface#13960BeryJu merged 3 commits intogoauthentik:mainfrom
BeryJu merged 3 commits intogoauthentik:mainfrom
Conversation
When using a custom SVG file (or mabye other types, TBH I didn't check, I should) for a branded logo, the logo would flash the stock authentik logo for a moment before the custom logo appears on the Admin interface. This was happening because the brand configuration was being loaded asynchronously through the context provider, causing a brief moment where the default logo was shown. Closes #3228 Closes #13739
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13960 +/- ##
==========================================
- Coverage 92.75% 92.70% -0.06%
==========================================
Files 809 809
Lines 41533 41533
==========================================
- Hits 38526 38504 -22
- Misses 3007 3029 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
approved these changes
Apr 25, 2025
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 25, 2025
* main: (33 commits) website/integrations: adds missing trailing slash in homarr doc (#14249) lifecycle: fix test-all in docker (#14244) core, web: update translations (#14243) web/admin: prevent default logo flashing in admin interface (#13960) website/docs: Update release notes for 2025.4 (#14158) core, web: update translations (#14241) Updates for file web/xliff/en.xlf in zh_TW [Manual Sync] (#14225) translate: Updates for file web/xliff/en.xlf in nl [Manual Sync] (#14217) translate: Updates for file web/xliff/en.xlf in fi [Manual Sync] (#14219) translate: Updates for file web/xliff/en.xlf in de [Manual Sync] (#14220) translate: Updates for file web/xliff/en.xlf in fr [Manual Sync] (#14221) translate: Updates for file web/xliff/en.xlf in pl [Manual Sync] (#14222) translate: Updates for file locale/en/LC_MESSAGES/django.po in es [Manual Sync] (#14223) translate: Updates for file web/xliff/en.xlf in zh-Hans [Manual Sync] (#14224) translate: Updates for file locale/en/LC_MESSAGES/django.po in de [Manual Sync] (#14226) translate: Updates for file locale/en/LC_MESSAGES/django.po in fi [Manual Sync] (#14227) translate: Updates for file web/xliff/en.xlf in tr [Manual Sync] (#14228) translate: Updates for file locale/en/LC_MESSAGES/django.po in pl [Manual Sync] (#14229) translate: Updates for file locale/en/LC_MESSAGES/django.po in ko [Manual Sync] (#14230) translate: Updates for file locale/en/LC_MESSAGES/django.po in it [Manual Sync] (#14231) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a custom SVG file (or mabye other types, TBH I didn't check, I should) for a branded logo, the logo would flash the stock authentik logo for a moment before the custom logo appears on the Admin interface.
This was happening because the brand configuration was being loaded asynchronously through the context provider, causing a brief moment where the default logo was shown.
Closes #3228 Closes #13739
Details
REPLACE ME
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)