brands: fix migration 0008 by removing incorrect context manager usage#13635
Merged
BeryJu merged 1 commit intogoauthentik:mainfrom Mar 23, 2025
Merged
Conversation
Member
Author
|
cc @BeryJu |
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13635 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 794 794
Lines 40508 40508
=======================================
+ Hits 37572 37575 +3
+ Misses 2936 2933 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BeryJu
approved these changes
Mar 23, 2025
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 25, 2025
* main: (76 commits) admin: fix system API when using bearer token (#13651) website: bump the build group in /website with 6 updates (#13645) core: bump goauthentik.io/api/v3 from 3.2025022.5 to 3.2025022.6 (#13646) translate: Updates for file web/xliff/en.xlf in fr (#13653) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#13652) website/integrations: add tandoor (#13560) core, web: update translations (#13642) providers/scim: fix group membership check failing (#13644) ci: add semgrep (#13643) flows: fix API not returning configured background (#13641) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#13631) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#13633) translate: Updates for file web/xliff/en.xlf in zh_CN (#13632) translate: Updates for file web/xliff/en.xlf in zh-Hans (#13634) brands: fix migration 0008 by removing incorrect context manager usage (#13635) web: Fix prop. (#13630) core, web: update translations (#13628) web/admin: reworked sync status card (#13625) core: bump github.com/golang-jwt/jwt/v5 from 5.2.1 to 5.2.2 (#13626) translate: Updates for file web/xliff/en.xlf in zh-Hans (#13622) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration was incorrectly using Path.read_text() with a context manager,
which caused a TypeError. Fixed by directly reading the file content since
read_text() returns a string, not a context manager.
Error Log
Tested-On: HEAD at 3eccef8
Details
REPLACE ME
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)