website/integrations: add tandoor by chwshka · Pull Request #13560 · goauthentik/authentik

chwshka · 2025-03-18T09:13:10Z

Details

Adds documentation on integrating Tandoor recipe manager with authentik.

This would close #6609

Checklist

Inapplicable

- [ ] Local tests pass (`ak test authentik/`) - [ ] The code has been formatted (`make lint-fix`)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

netlify · 2025-03-18T09:13:31Z

✅ Deploy Preview for authentik-storybook canceled.

Name	Link
🔨 Latest commit	`ff7472d`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/67dbd9d757226f000811540e

netlify · 2025-03-18T09:13:32Z

✅ Deploy Preview for authentik-docs ready!

Name	Link
🔨 Latest commit	`ff7472d`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-docs/deploys/67dbd9d7eb3e2d00083d7b30
😎 Deploy Preview	https://deploy-preview-13560--authentik-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dominic-r

@chwshka Thank you for opening this PR, it is greatly appreciated. Here are a few suggestions to get your review going. Please do LMK if you have any questions concerning this review!

website/integrations/services/tandoor/index.md

Co-authored-by: Dominic R <dominic@sdko.org> Signed-off-by: Dewi Roberts <chwshka@outlook.com>

chwshka · 2025-03-18T13:35:32Z

@dominic-r I think I've matched the document with the new template. Let me know if you spot anything else.

dominic-r

Thanks. Here are a few more related to that new section. Otherwise, this looks pretty good!

website/integrations/services/tandoor/index.md

Co-authored-by: Dominic R <dominic@sdko.org> Signed-off-by: Dewi Roberts <chwshka@outlook.com>

dominic-r · 2025-03-19T16:29:37Z

@chwshka Hi, I notice the documentation build is failing. Before merging, these errors would need to be resolved. Can you take a look at this when you have a second? Thanks

dominic-r · 2025-03-19T16:31:44Z

By the looks of it, the error is in the provider configuration, KBD isn't meant for multi line code blocks, you should use ``` instead

chwshka · 2025-03-19T20:42:42Z

By the looks of it, the error is in the provider configuration, KBD isn't meant for multi line code blocks, you should use ``` instead

That's fixed. The codeblock is now using ```. The environment variables codeblock includes <em></em> sections. I assume this is ok?

website/integrations/services/tandoor/index.md

codecov · 2025-03-20T13:07:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (ad27f26) to head (ff7472d).
Report is 71 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13560      +/-   ##
==========================================
+ Coverage   92.73%   92.76%   +0.02%     
==========================================
  Files         794      794              
  Lines       40425    40493      +68     
==========================================
+ Hits        37487    37562      +75     
+ Misses       2938     2931       -7

Flag	Coverage Δ
e2e	`47.96% <ø> (-0.02%)`	⬇️
integration	`24.28% <ø> (-0.03%)`	⬇️
unit	`90.52% <ø> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tanberry · 2025-03-20T13:58:56Z

Hi @chwshka thanks for this PR. Thanks also for linking to PR# #6609. Was it not possible to add to that PR, and co-author it with the original contributor? Maybe not, perhaps the technical details had changed too much, but I wanted to ask. We can go ahead and merge yours, and if OK with you, in the closing comments I'd like to acknowledge the work the original contributor(s) did?

chwshka · 2025-03-20T14:03:42Z

Hi @chwshka thanks for this PR. Thanks also for linking to PR# #6609. Was it not possible to add to that PR, and co-author it with the original contributor? Maybe not, perhaps the technical details had changed too much, but I wanted to ask. We can go ahead and merge yours, and if OK with you, in the closing comments I'd like to acknowledge the work the original contributor(s) did?

That probably would have been better. I'll do that next time. I'd be happy to have the author of #6609 acknowledged.

dominic-r

LGTM! Thanks

tanberry

Thanks @chwshka for this contribution, and thanks also to @fyksen and several others for their work on the original #6609 PR. It's great to have Tandoor integration now documented!

* main: (76 commits) admin: fix system API when using bearer token (#13651) website: bump the build group in /website with 6 updates (#13645) core: bump goauthentik.io/api/v3 from 3.2025022.5 to 3.2025022.6 (#13646) translate: Updates for file web/xliff/en.xlf in fr (#13653) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#13652) website/integrations: add tandoor (#13560) core, web: update translations (#13642) providers/scim: fix group membership check failing (#13644) ci: add semgrep (#13643) flows: fix API not returning configured background (#13641) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#13631) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#13633) translate: Updates for file web/xliff/en.xlf in zh_CN (#13632) translate: Updates for file web/xliff/en.xlf in zh-Hans (#13634) brands: fix migration 0008 by removing incorrect context manager usage (#13635) web: Fix prop. (#13630) core, web: update translations (#13628) web/admin: reworked sync status card (#13625) core: bump github.com/golang-jwt/jwt/v5 from 5.2.1 to 5.2.2 (#13626) translate: Updates for file web/xliff/en.xlf in zh-Hans (#13622) ...

website/integrations: add tandoor

2fc1fdc

chwshka requested a review from a team as a code owner March 18, 2025 09:13

dominic-r requested changes Mar 18, 2025

View reviewed changes

chwshka and others added 5 commits March 18, 2025 15:18

Update website/integrations/services/tandoor/index.md

e9a61cf

Co-authored-by: Dominic R <dominic@sdko.org> Signed-off-by: Dewi Roberts <chwshka@outlook.com>

Update website/integrations/services/tandoor/index.md

5a04099

Co-authored-by: Dominic R <dominic@sdko.org> Signed-off-by: Dewi Roberts <chwshka@outlook.com>

Update website/integrations/services/tandoor/index.md

49895a3

Co-authored-by: Dominic R <dominic@sdko.org> Signed-off-by: Dewi Roberts <chwshka@outlook.com>

Update website/integrations/services/tandoor/index.md

4ed14ad

Co-authored-by: Dominic R <dominic@sdko.org> Signed-off-by: Dewi Roberts <chwshka@outlook.com>

Updated to match recommendations

320fb5d

dominic-r requested changes Mar 18, 2025

View reviewed changes

chwshka and others added 3 commits March 18, 2025 15:53

Update website/integrations/services/tandoor/index.md

e6939ea

Co-authored-by: Dominic R <dominic@sdko.org> Signed-off-by: Dewi Roberts <chwshka@outlook.com>

Further updates to match suggestions

1b38607

Updated to use <kbd> and <em> tags

5f77198

fixed codeblock

9296b4c

dominic-r reviewed Mar 19, 2025

View reviewed changes

website/integrations/services/tandoor/index.md Show resolved Hide resolved

dominic-r reviewed Mar 19, 2025

View reviewed changes

website/integrations/services/tandoor/index.md Show resolved Hide resolved

chwshka added 2 commits March 19, 2025 22:55

Added explanatory text and removed extra EM tags

8888722

fixed prettier issue

e9aa4cd

dominic-r reviewed Mar 19, 2025

View reviewed changes

website/integrations/services/tandoor/index.md Outdated Show resolved Hide resolved

moved ` to line 52

ff7472d

dominic-r approved these changes Mar 20, 2025

View reviewed changes

tanberry approved these changes Mar 24, 2025

View reviewed changes

tanberry merged commit 59d20e3 into goauthentik:main Mar 24, 2025
87 checks passed

Uh oh!

Conversation

chwshka commented Mar 18, 2025

Details

Checklist

Uh oh!

netlify bot commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook canceled.

Uh oh!

netlify bot commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-docs ready!

Uh oh!

dominic-r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chwshka commented Mar 18, 2025

Uh oh!

dominic-r left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dominic-r commented Mar 19, 2025

Uh oh!

dominic-r commented Mar 19, 2025

Uh oh!

chwshka commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tanberry commented Mar 20, 2025

Uh oh!

chwshka commented Mar 20, 2025

Uh oh!

dominic-r left a comment

Choose a reason for hiding this comment

Uh oh!

tanberry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Mar 18, 2025 •

edited

Loading

netlify bot commented Mar 18, 2025 •

edited

Loading

dominic-r left a comment •

edited

Loading

chwshka commented Mar 19, 2025 •

edited

Loading

codecov bot commented Mar 20, 2025 •

edited

Loading