Skip to content

web/admin: fix comment being rendered#13530

Merged
BeryJu merged 2 commits intomainfrom
web/admin/fix-comment-rendering
Mar 14, 2025
Merged

web/admin: fix comment being rendered#13530
BeryJu merged 2 commits intomainfrom
web/admin/fix-comment-rendering

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Mar 14, 2025

Details

followup from #13331


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner March 14, 2025 14:12
@netlify
Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit bc611ef
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67d43ef552bf2a0008a2e6c7

@netlify
Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit bc611ef
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67d43ef5fa2f240008d264fc
😎 Deploy Preview https://deploy-preview-13530--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (78a02ff) to head (bc611ef).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13530      +/-   ##
==========================================
+ Coverage   92.68%   92.73%   +0.05%     
==========================================
  Files         794      794              
  Lines       40418    40418              
==========================================
+ Hits        37462    37483      +21     
+ Misses       2956     2935      -21     
Flag Coverage Δ
e2e 47.98% <ø> (+0.02%) ⬆️
integration 24.31% <ø> (ø)
unit 90.51% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-bc611ef587cc4e7f8bd31806ee73d634e6c1e0c7
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-bc611ef587cc4e7f8bd31806ee73d634e6c1e0c7

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit b445cff into main Mar 14, 2025
85 checks passed
@BeryJu BeryJu deleted the web/admin/fix-comment-rendering branch March 14, 2025 14:52
kensternberg-authentik added a commit that referenced this pull request Apr 25, 2025
* main:
  website/docs: dev docs: bump node/postgres requirements  (#13516)
  sources: prevent deletion of built-in source (#12914)
  core: bump django-tenants (#13536)
  website/docs: dev docs: full: remove note on installing shell plugin (#13515)
  sources/oauth: fix duplicate authentication (#13322)
  web/admin: fix comment being rendered (#13530)
  core: Bump aws-cdk-lib from 2.183.0 to 2.184.0 (#13522)
  core, web: update translations (#13520)
  lifecycle/aws: Bump aws-cdk from 2.1003.0 to 2.1004.0 in /lifecycle/aws (#13524)
  core: Bump github.com/coreos/go-oidc/v3 from 3.12.0 to 3.13.0 (#13525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants