sources: prevent deletion of built-in source#12914
Merged
BeryJu merged 16 commits intogoauthentik:mainfrom Mar 14, 2025
Merged
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12914 +/- ##
==========================================
- Coverage 92.76% 92.74% -0.03%
==========================================
Files 785 785
Lines 39636 39643 +7
==========================================
- Hits 36768 36765 -3
- Misses 2868 2878 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Dominic R <git@sdko.org>
Member
Author
|
Hi @BeryJu. Sorry to bother. Do you think you could take a look at this when you have a second? Thanks |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
rissson
reviewed
Feb 12, 2025
rissson
approved these changes
Feb 13, 2025
Member
Author
BeryJu
approved these changes
Mar 14, 2025
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 25, 2025
* main: website/docs: dev docs: bump node/postgres requirements (#13516) sources: prevent deletion of built-in source (#12914) core: bump django-tenants (#13536) website/docs: dev docs: full: remove note on installing shell plugin (#13515) sources/oauth: fix duplicate authentication (#13322) web/admin: fix comment being rendered (#13530) core: Bump aws-cdk-lib from 2.183.0 to 2.184.0 (#13522) core, web: update translations (#13520) lifecycle/aws: Bump aws-cdk from 2.1003.0 to 2.1004.0 in /lifecycle/aws (#13524) core: Bump github.com/coreos/go-oidc/v3 from 3.12.0 to 3.13.0 (#13525)
This was referenced Apr 30, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdko/sources/no-delete-built-in
What?
This PR modifies
renderToolbarSelectedto disable the "Delete" button for the built-in authentik login source. While the source will reappear after a server restart, the change is intended as a precaution to prevent potential issues by blocking deletion. Furthermore, it adds a function to theSourceViewSetclass to return an error when attmpting to delete the source using the API url.Testing:
Details
REPLACE ME
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)