providers/rac: fix signals and Endpoint caching#13529
Merged
gergosimonyi merged 2 commits intomainfrom Mar 14, 2025
Merged
Conversation
And possibly other things by not using `ManagedAppConfig`. This was broken by 2128e7f.
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook canceled.
|
Collaborator
Author
|
/cherry-pick 2025.2 |
This will result in more invalidations, but it will also fix some invalid Endpoint instances from showing up in Endpoint lists. Since an Endpoint can be tied to a Policy, some invalid results can still show up if the result of the Policy changes (either because the Policy itself changes or because data checked by that Policy changes). Even with those potentially invalid results, I believe the caching itself is advantageous as long as the API provides an option for `superuser_full_list`.
ef87116 to
d7767c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #13529 +/- ##
==========================================
+ Coverage 92.68% 92.74% +0.05%
==========================================
Files 794 794
Lines 40419 40418 -1
==========================================
+ Hits 37462 37485 +23
+ Misses 2957 2933 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d7767c1702ff1a6b457cd6cd36d3ce55a15abd39
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-d7767c1702ff1a6b457cd6cd36d3ce55a15abd39Afterwards, run the upgrade commands from the latest release notes. |
BeryJu
approved these changes
Mar 14, 2025
Collaborator
Author
|
/cherry-pick version-2025.2 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
* fix RAC signals And possibly other things by not using `ManagedAppConfig`. This was broken by 2128e7f. * invalidate Endpoint cache on update or delete This will result in more invalidations, but it will also fix some invalid Endpoint instances from showing up in Endpoint lists. Since an Endpoint can be tied to a Policy, some invalid results can still show up if the result of the Policy changes (either because the Policy itself changes or because data checked by that Policy changes). Even with those potentially invalid results, I believe the caching itself is advantageous as long as the API provides an option for `superuser_full_list`.
rissson
pushed a commit
that referenced
this pull request
Mar 14, 2025
…13531) providers/rac: fix signals and Endpoint caching (#13529) * fix RAC signals And possibly other things by not using `ManagedAppConfig`. This was broken by 2128e7f. * invalidate Endpoint cache on update or delete This will result in more invalidations, but it will also fix some invalid Endpoint instances from showing up in Endpoint lists. Since an Endpoint can be tied to a Policy, some invalid results can still show up if the result of the Policy changes (either because the Policy itself changes or because data checked by that Policy changes). Even with those potentially invalid results, I believe the caching itself is advantageous as long as the API provides an option for `superuser_full_list`. Co-authored-by: Simonyi Gergő <28359278+gergosimonyi@users.noreply.github.com>
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 25, 2025
* main: (44 commits) providers/rac: fix signals and Endpoint caching (#13529) web/flows: fix missing padding on authenticator_validate card (#13420) web/user: show admin interface button on mobile (#13421) website: Bump the build group in /website with 6 updates (#13501) core: Bump goauthentik.io/api/v3 from 3.2025021.3 to 3.2025021.4 (#13495) core: Bump importlib-metadata from 8.5.0 to 8.6.1 (#13499) core: Bump msgraph-sdk from 1.23.0 to 1.24.0 (#13500) core: Bump google-api-python-client from 2.163.0 to 2.164.0 (#13498) core: Bump aws-cdk-lib from 2.182.0 to 2.183.0 (#13496) core: Bump psycopg from 3.2.5 to 3.2.6 (#13497) translate: Updates for file web/xliff/en.xlf in fr (#13514) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#13513) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#13510) translate: Updates for file web/xliff/en.xlf in zh-Hans (#13511) translate: Updates for file web/xliff/en.xlf in zh_CN (#13509) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#13508) core, web: update translations (#13494) website: remove the last updated option from footer (#13493) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#13487) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#13488) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will result in more invalidations, but it will also fix some
invalid Endpoint instances from showing up in Endpoint lists.
Since an Endpoint can be tied to a Policy, some invalid results can
still show up if the result of the Policy changes (either because the
Policy itself changes or because data checked by that Policy changes).
Even with those potentially invalid results, I believe the caching
itself is advantageous as long as the API provides an option for
superuser_full_list.Closes #13231
Closes #13237