providers/rac: fix signals and Endpoint caching (cherry-pick #13529)#13531
Merged
rissson merged 1 commit intoversion-2025.2from Mar 14, 2025
Merged
providers/rac: fix signals and Endpoint caching (cherry-pick #13529)#13531rissson merged 1 commit intoversion-2025.2from
rissson merged 1 commit intoversion-2025.2from
Conversation
* fix RAC signals And possibly other things by not using `ManagedAppConfig`. This was broken by 2128e7f. * invalidate Endpoint cache on update or delete This will result in more invalidations, but it will also fix some invalid Endpoint instances from showing up in Endpoint lists. Since an Endpoint can be tied to a Policy, some invalid results can still show up if the result of the Policy changes (either because the Policy itself changes or because data checked by that Policy changes). Even with those potentially invalid results, I believe the caching itself is advantageous as long as the API provides an option for `superuser_full_list`.
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## version-2025.2 #13531 +/- ##
==================================================
- Coverage 92.73% 92.66% -0.08%
==================================================
Files 793 793
Lines 40299 40298 -1
==================================================
- Hits 37372 37342 -30
- Misses 2927 2956 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked providers/rac: fix signals and Endpoint caching (#13529)
And possibly other things by not using
ManagedAppConfig. This wasbroken by 2128e7f.
This will result in more invalidations, but it will also fix some
invalid Endpoint instances from showing up in Endpoint lists.
Since an Endpoint can be tied to a Policy, some invalid results can
still show up if the result of the Policy changes (either because the
Policy itself changes or because data checked by that Policy changes).
Even with those potentially invalid results, I believe the caching
itself is advantageous as long as the API provides an option for
superuser_full_list.