Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs canceled.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13492 +/- ##
==========================================
- Coverage 93.17% 92.70% -0.48%
==========================================
Files 831 831
Lines 44251 44469 +218
==========================================
- Hits 41230 41224 -6
- Misses 3021 3245 +224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
tanberry
left a comment
There was a problem hiding this comment.
Thanks for answering my questions from my first review; I'd still like to add an image of the retry icon but not really required. I re-edited a few areas based on your answers, please confirm that they look right, and there is one question, but yeah, LGTM!!
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
This reverts commit 70d9d53.
This reverts commit 52bbc82.
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
BeryJu
left a comment
There was a problem hiding this comment.
need a way to run the bootstrap blueprint when AUTHENTIK_BOOTSTRAP_* is set, and ideally a way to run the worker with ak server in development, otherwise LGTM
… defined Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
* main: (91 commits) *: replace Celery with Dramatiq (#13492) website/docs: stages/mtls: Clean up stage configuration section (#15753) translate: Updates for file locale/en/LC_MESSAGES/django.po in es (#15818) website: bump the eslint group in /website with 2 updates (#15805) web: bump typedoc from 0.28.7 to 0.28.8 in /packages/esbuild-plugin-live-reload (#15809) core: bump axllent/mailpit from v1.27.1 to v1.27.2 in /tests/e2e (#15813) web: bump the rollup group across 1 directory with 4 updates (#15806) web: bump the eslint group across 3 directories with 2 updates (#15808) lifecycle/aws: bump cross-env from 7.0.3 to 10.0.0 in /lifecycle/aws (#15807) web: bump ts-pattern from 5.7.1 to 5.8.0 in /web (#15810) web: bump @sentry/browser from 9.41.0 to 9.42.0 in /web in the sentry group across 1 directory (#15811) web: Add support for placeholder in <ak-text-input> (#15795) providers/rac: fix incorrect caching (#15779) root: support for custom postgresql connection options (#15577) website: bump the build group in /website with 3 updates (#15784) web: bump @sentry/browser from 9.40.0 to 9.41.0 in /web in the sentry group across 1 directory (#15785) core: bump astral-sh/uv from 0.8.2 to 0.8.3 (#15786) lifecycle/aws: bump aws-cdk from 2.1021.0 to 2.1022.0 in /lifecycle/aws (#15787) core: bump twilio from 9.6.5 to 9.7.0 (#15788) revert: web: Font fixes (#15581) (#15789) ...
Details
Old TODO:
ak workerin commands to runTODO when extracting the code to its package:
TODO that modify a bit the implementation:
run_on_startupas an argument to a middleware dispatching the tasks on worker bootTODO things to figure out:
TODO cleanup:
TODO frontend:
TODO docs:
authentik_admin_workersmetric ->authentik_tasks_workersTODO deploy:
closes #15652
closes #14824
closes #14818
closes #9252
closes #13147
closes #6815
closes #9976
closes #6839
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)