Skip to content

root: add priority to celery queues#6845

Closed
BeryJu wants to merge 1 commit intomainfrom
root/replace-celery-queue-priority
Closed

root: add priority to celery queues#6845
BeryJu wants to merge 1 commit intomainfrom
root/replace-celery-queue-priority

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Sep 11, 2023

Details

#6844

we used to use celery queues but don't really expose them or use them for routing, it makes more sense with priorities and actually using them for routing (allthough maybe we should keep queues?)


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner September 11, 2023 17:35
@BeryJu BeryJu requested review from smilelyj and removed request for a team September 11, 2023 17:35
@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 7d1efd7
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/652fb8781c2b750008cb804d

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (3514723) to head (7d1efd7).
Report is 3967 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6845      +/-   ##
==========================================
- Coverage   92.64%   92.49%   -0.16%     
==========================================
  Files         584      584              
  Lines       28680    28691      +11     
==========================================
- Hits        26572    26539      -33     
- Misses       2108     2152      +44     
Flag Coverage Δ
e2e 50.48% <100.00%> (-0.72%) ⬇️
integration 26.16% <100.00%> (+0.02%) ⬆️
unit 89.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-replace-celery-queue-priority-1694454613-ff80bb2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-replace-celery-queue-priority-1694454613-ff80bb2-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-replace-celery-queue-priority-1694454613-ff80bb2

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-replace-celery-queue-priority-1694454613-ff80bb2-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu force-pushed the root/replace-celery-queue-priority branch from ff80bb2 to 578a4aa Compare October 18, 2023 10:50
@BeryJu BeryJu requested a review from a team as a code owner October 18, 2023 10:50
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the root/replace-celery-queue-priority branch from 578a4aa to 7d1efd7 Compare October 18, 2023 10:50
Copy link
Contributor

@smusali smusali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understandable and lgtm

@BeryJu BeryJu changed the title root: replace celery queues with priority root: add priority to celery queues Mar 15, 2024
@rissson rissson mentioned this pull request Mar 12, 2025
59 tasks
@BeryJu BeryJu closed this Mar 20, 2025
@BeryJu BeryJu deleted the root/replace-celery-queue-priority branch March 20, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants