Skip to content

web/user: fix opening application with Enter not respecting new tab setting#13115

Merged
BeryJu merged 1 commit intomainfrom
web/user/fix-enter-new-tab
Feb 19, 2025
Merged

web/user: fix opening application with Enter not respecting new tab setting#13115
BeryJu merged 1 commit intomainfrom
web/user/fix-enter-new-tab

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Feb 19, 2025

Details

closes #11740


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

…etting

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner February 19, 2025 13:36
@netlify
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 775ec5c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67b5de755aa80b0008e37ed6

@netlify
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 775ec5c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67b5de75d82ec1000821bd8c
😎 Deploy Preview https://deploy-preview-13115--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (c67de17) to head (775ec5c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13115      +/-   ##
==========================================
+ Coverage   92.75%   92.77%   +0.01%     
==========================================
  Files         792      792              
  Lines       40197    40197              
==========================================
+ Hits        37286    37291       +5     
+ Misses       2911     2906       -5     
Flag Coverage Δ
e2e 48.18% <ø> (+0.05%) ⬆️
integration 24.13% <ø> (ø)
unit 90.48% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu
Copy link
Member Author

BeryJu commented Feb 19, 2025

/cherry-pick version-2025.2

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-775ec5cacaa85b7750ce31247b24decffa971e8e
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-775ec5cacaa85b7750ce31247b24decffa971e8e

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 6facb58 into main Feb 19, 2025
90 checks passed
@BeryJu BeryJu deleted the web/user/fix-enter-new-tab branch February 19, 2025 14:49
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Feb 19, 2025
…etting (#13115)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@benedikt-bartscher
Copy link

Thank you very much @BeryJu

BeryJu added a commit that referenced this pull request Feb 19, 2025
…etting (cherry-pick #13115) (#13118)

web/user: fix opening application with Enter not respecting new tab setting (#13115)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Feb 20, 2025
* main:
  web/user: fix opening application with Enter not respecting new tab setting (#13115)
  web: bump API Client version (#13113)
  providers/rac: move to open source (#13015)
  website/docs: add 2025.2 release notes (#13002)
  core: clear expired database sessions (#13105)
  core: bump sentry-sdk from 2.21.0 to 2.22.0 (#13098)
  core: bump bandit from 1.8.2 to 1.8.3 (#13097)
  core: bump aws-cdk-lib from 2.178.2 to 2.179.0 (#13099)
  core: bump goauthentik.io/api/v3 from 3.2024123.4 to 3.2024123.6 (#13100)
  lifecycle/aws: bump aws-cdk from 2.178.2 to 2.179.0 in /lifecycle/aws (#13101)
  website/docs: Add AdventureLog Community Integration Documentation (#12928)
  website/docs: minor fixes (#13095)
  website/integrations: Update to Wizard and Styling Guide (#12919)
  web: bump API Client version (#13093)
  policies/geoip: distance + impossible travel (#12541)
  root: fix generated API docs not being excluded from codespell (#13091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selecting Application with Keyboard does not open in new Tab

2 participants